chrome/common/extensions/api/_api_features.json - Issue 850603003: Add a 'nocompile' option to Extension feature files, and annotate all Devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/_api_features.json

Issue 850603003: Add a 'nocompile' option to Extension feature files, and annotate all Devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_bindings_apitest.cc ('k') | chrome/test/data/extensions/api_test/bindings/nocompile/devtools.html » ('j') | extensions/common/features/base_feature_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/_api_features.json

diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json

index 90b1befc9de9ba7b1061a203c84d792d20d7dd7c..b5520540db4393fc027f8d22accc1352f4b6d57b 100644

--- a/chrome/common/extensions/api/_api_features.json

+++ b/chrome/common/extensions/api/_api_features.json

@@ -234,15 +234,19 @@

"dependencies": ["permission:developerPrivate"],

"contexts": ["blessed_extension"]

+ // All devtools APIs are implemented by hand, so don't compile them.

"devtools.inspectedWindow": {

+ "nocompile": true,

"dependencies": ["manifest:devtools_page"],

"contexts": ["blessed_extension"]

"devtools.network": {

+ "nocompile": true,

"dependencies": ["manifest:devtools_page"],

"contexts": ["blessed_extension"]

"devtools.panels": {

+ "nocompile": true,

"dependencies": ["manifest:devtools_page"],

"contexts": ["blessed_extension"]