Add a 'nocompile' option to Extension feature files, and annotate all Devtools

Add a 'nocompile' option to Extension feature files, and annotate all Devtools
APIs with it. Devtools APIs are written by hand and don't need to be compiled
(moreover, it crashes when you try).

BUG=356133
R=mek@chromium.org

Committed: https://crrev.com/1bd5b187a8868df3f0f2998e4ad770fd31c04846
Cr-Commit-Position: refs/heads/master@{#311302}

[Marijn Kruisselbrink, 2015-01-13 01:06:10]

You have the wrong bug number in the description

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
File extensions/common/features/base_feature_provider.cc (right):

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
extensions/common/features/base_feature_provider.cc:22: const
base::DictionaryValue* as_dict = NULL;
nullptr is recommended over NULL for new code

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
extensions/common/features/base_feature_provider.cc:24:
as_dict->GetBoolean("nocompile", &nocompile);
Would it make sense to DCHECK for the situation where there is a "nocompile"
property, but it isn't a boolean?

[not at google - send to devlin, 2015-01-13 01:14:52]

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
File extensions/common/features/base_feature_provider.cc (right):

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
extensions/common/features/base_feature_provider.cc:22: const
base::DictionaryValue* as_dict = NULL;
On 2015/01/13 01:06:10, Marijn Kruisselbrink wrote:
> nullptr is recommended over NULL for new code

Done. It irritated me having one instance of nullptr in this file and a bunch of
NULLs, so I changed them all.

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
extensions/common/features/base_feature_provider.cc:24:
as_dict->GetBoolean("nocompile", &nocompile);
On 2015/01/13 01:06:10, Marijn Kruisselbrink wrote:
> Would it make sense to DCHECK for the situation where there is a "nocompile"
> property, but it isn't a boolean?

Eh... it adds 2 lines of code, and we don't check anywhere else. Hopefully
nobody will write "nocompile": 0 or something.

[Marijn Kruisselbrink, 2015-01-13 01:19:59]

lgtm

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
File extensions/common/features/base_feature_provider.cc (right):

https://codereview.chromium.org/850603003/diff/20001/extensions/common/featur...
extensions/common/features/base_feature_provider.cc:24:
as_dict->GetBoolean("nocompile", &nocompile);
On 2015/01/13 01:14:52, kalman wrote:
> On 2015/01/13 01:06:10, Marijn Kruisselbrink wrote:
> > Would it make sense to DCHECK for the situation where there is a "nocompile"
> > property, but it isn't a boolean?
> 
> Eh... it adds 2 lines of code, and we don't check anywhere else. Hopefully
> nobody will write "nocompile": 0 or something.

Okay, makes sense. Yeah, it seems a bit arbitrary which format requirements are
CHECKs, NOTREACHED(), LOG(ERROR) or just ignored...

[not at google - send to devlin, 2015-01-13 01:32:13]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:33:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850603003/40001

[commit-bot: I haz the power, 2015-01-13 01:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:55:33]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[not at google - send to devlin, 2015-01-13 05:05:57]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-01-13 05:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850603003/40001

[commit-bot: I haz the power, 2015-01-13 05:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 05:36:59]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[not at google - send to devlin, 2015-01-13 17:46:54]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-01-13 17:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850603003/60001

[commit-bot: I haz the power, 2015-01-13 19:01:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-13 19:03:54]

Patchset 4 (id:??) landed as
https://crrev.com/1bd5b187a8868df3f0f2998e4ad770fd31c04846
Cr-Commit-Position: refs/heads/master@{#311302}