Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 8506028: Merge 99485 - Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames (Closed)

Created:
9 years, 1 month ago by Vangelis Kokkevis
Modified:
9 years, 1 month ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 99485 - Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames that forceCompositingMode can be used without turning frames into composited layers. https://bugs.webkit.org/show_bug.cgi?id=71714 Reviewed by James Robinson. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled): (WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): * testing/Internals.cpp: (WebCore::Internals::setEnableCompositingForScrollableFrames): * testing/Internals.h: * testing/Internals.idl: LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from forceCompositingMode. https://bugs.webkit.org/show_bug.cgi?id=71714 Adjust the force-compositing-mode layout tests to explicitly set the new flag. Reviewed by James Robinson. * platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: * platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html: * platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html: * platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html: * platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html: * platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html: TBR=vangelis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html View 1 chunk +3 lines, -1 line 0 comments Download
M Source/WebCore/page/Settings.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vangelis Kokkevis
9 years, 1 month ago (2011-11-09 22:08:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698