Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 850593003: Examples: move markAsLaidOut() to just before the return, so the asserts work (Closed)

Created:
5 years, 11 months ago by Hixie
Modified:
5 years, 11 months ago
Reviewers:
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Examples: move markAsLaidOut() to just before the return, so the asserts work Specs: introduce layoutDescendants() to avoid work when a layout manager is unaffected by its childrens' intrinsic dimensions Examples: update for layoutDescendants() change Specs: add "lifetime" to resolver settings so that a transition can avoid having to dirty every consumer of the property every frame when it only needs to update the objects that are changing that frame Specs: expose the parents on AbstractStyleDeclarationList subclasses Specs: fix documentation around autoreap Specs: fix definition of setProperty() Specs: clean up the dimension-related logic of layout managers Committed: https://chromium.googlesource.com/external/mojo/+/cb520e20671568b4d7d287cb8d14df9e90ad95df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -55 lines) Patch
M sky/examples/style/block-layout.sky View 2 chunks +4 lines, -1 line 0 comments Download
M sky/examples/style/hex-layout.sky View 3 chunks +5 lines, -2 lines 0 comments Download
M sky/examples/style/toolbar-layout.sky View 3 chunks +5 lines, -2 lines 0 comments Download
M sky/specs/style.md View 9 chunks +95 lines, -50 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hixie
5 years, 11 months ago (2015-01-13 19:25:27 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb520e20671568b4d7d287cb8d14df9e90ad95df.

Powered by Google App Engine
This is Rietveld 408576698