Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3060)

Unified Diff: sky/tools/skydb

Issue 850533004: Make --gdb explain that it doesn't work right now (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/skydb
diff --git a/sky/tools/skydb b/sky/tools/skydb
index ad4ceed1be8ea01783139381461be3df935693cb..191d6d1de938973bcf690b0a7aec3384d28a9ba1 100755
--- a/sky/tools/skydb
+++ b/sky/tools/skydb
@@ -115,10 +115,6 @@ class SkyDebugger(object):
else:
shell_command = [self.paths.mojo_shell_path] + shell_args
- # FIXME: This doesn't work for android
- if args.gdb:
- shell_command = ['gdb'] + shell_command
-
return shell_command
def _connect_to_device(self):
@@ -181,6 +177,12 @@ class SkyDebugger(object):
print ' '.join(map(pipes.quote, shell_command))
self.pids['mojo_shell_pid'] = subprocess.Popen(shell_command).pid
+ if args.gdb:
+ print "Sorry, I'm not sure how best to wire up --gdb to work"
+ print "with mojo_shell as a background process. For now use:"
+ print "gdb --pid %s" % self.pids['mojo_shell_pid']
+ shell_command = ['gdb'] + shell_command
+
if not self._wait_for_sky_command_port():
logging.error('Failed to start sky')
self.stop_command(None)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698