Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 85053002: Increment CSSSegmentedFontFaceCache version when removing FontFaceRule (Closed)

Created:
7 years ago by Kunihiko Sakamoto
Modified:
7 years ago
Reviewers:
tkent, tasak, dglazkov
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Increment CSSSegmentedFontFaceCache version when removing FontFaceRule This prevents old font data (before the style change) from being used. BUG=305885 TEST=no test, this code path is not used yet Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/css/CSSSegmentedFontFaceCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kunihiko Sakamoto
7 years ago (2013-11-25 03:56:29 UTC) #1
tasak
lgtm. I really need this patch for https://codereview.chromium.org/82583005.
7 years ago (2013-11-25 04:01:23 UTC) #2
Kunihiko Sakamoto
Kent-san, could you give an OWNER-approval to this CL?
7 years ago (2013-11-25 04:04:52 UTC) #3
tkent
Why does this have no tests?
7 years ago (2013-11-25 04:22:46 UTC) #4
Kunihiko Sakamoto
On 2013/11/25 04:22:46, tkent wrote: > Why does this have no tests? Because this is ...
7 years ago (2013-11-25 04:26:25 UTC) #5
tkent
ok, lgtm.
7 years ago (2013-11-25 04:37:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/85053002/1
7 years ago (2013-11-25 04:38:44 UTC) #7
commit-bot: I haz the power
Change committed as 162598
7 years ago (2013-11-25 06:12:02 UTC) #8
tasak
7 years ago (2013-11-25 07:23:13 UTC) #9
Message was sent while issue was closed.
On 2013/11/25 06:12:02, I haz the power (commit-bot) wrote:
> Change committed as 162598

Thank you.

Powered by Google App Engine
This is Rietveld 408576698