Issue 850433002: During thread detach, delay final sweep until shutdown lock is held.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 850433002: During thread detach, delay final sweep until shutdown lock is held. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

During thread detach, delay final sweep until shutdown lock is held. Otherwise we risk re-scheduling a lazy sweep if the thread has to go via a safe point before proceeding to clean out and shut down. R=haraken BUG=357427 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188193

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	Source/platform/heap/ThreadState.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. ( The Heap::prepareHeapForTermination() asserts trigger fairly often on e.g., http/tests/workers/terminate-during-sync-operation-file.html atm. ...

5 years, 11 months ago (2015-01-10 17:13:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850433002/1

5 years, 11 months ago (2015-01-11 05:41:55 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-11 06:46:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188193

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages