Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_info_cb

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 384e57ad042fd34fc39677d21baad0864b765cce..06844924be2e22808e8c2176fe72bd3be647fdec 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -48,7 +48,9 @@ public:

static PassOwnPtrWillBeRawPtr<ServiceWorkerGlobalScopeClient> create(WebServiceWorkerContextClient&);

virtual ~ServiceWorkerGlobalScopeClientImpl();

- virtual void getClients(WebServiceWorkerClientsCallbacks*);

+ virtual void getClients(WebServiceWorkerClientsCallbacks*) override;

+ virtual void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) override;

virtual WebURL scope() const override;

virtual WebServiceWorkerCacheStorage* cacheStorage() const override;