[ServiceWorker] Implement ServiceWorkerClients.openWindow().

[ServiceWorker] Implement ServiceWorkerClients.openWindow().

This is allowing a service worker to open a window in some situations,
like during a notificationclick event handling.

BUG=437151
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189561

[mlamouri (slow - plz ping), 2015-01-15 22:40:09]

mlamouri@chromium.org changed reviewers:
+ michaeln@chromium.org, mkwst@chromium.org

[mlamouri (slow - plz ping), 2015-01-15 22:40:10]

Consider this as WIP.

It is still missing two things:
- cleanup regarding the check whether it's okay to open a new window;
- tests.

[mlamouri (slow - plz ping), 2015-01-15 22:42:04]

On 2015/01/15 at 22:40:10, Mounir Lamouri wrote:
> Consider this as WIP.
> 
> It is still missing two things:
> - cleanup regarding the check whether it's okay to open a new window;
> - tests.

Also, for some reasons, "about:flags" isn't detected as a "local" URL and can be
opened. Note that in order situations, it redirects to "chrome://flags" while
here, it stays as "about:flags".

[Mike West, 2015-01-16 11:43:25]

I think we should wait on this until the discussion in
https://codereview.chromium.org/844313002/ converges on something.

[mlamouri (slow - plz ping), 2015-01-28 12:29:06]

Mike, the questions regarding opening a window from a SW have been resolved. I
think this CL is good to go. I will add tests when the Chromium and Blink patch
will have landed.

PTAL.

[Mike West, 2015-01-28 13:43:59]

LGTM % questions.

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.cpp (right):

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:91:
resolver->reject(DOMException::create(SecurityError, "'" + parsedUrl.string() +
"' is cross origin. It cannot be opened."));
Nit: `parsedUrl.elidedString()`
Nit2: How about 'is not same-origin with the Worker.'?

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:95: if
(!context->isWindowInteractionAllowed()) {
Where is this defined?

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:99:
context->consumeWindowInteraction();
Ditto.

[michaeln, 2015-01-28 20:28:09]

r/s lgtm 2

[Michael van Ouwerkerk, 2015-01-30 14:56:28]

mvanouwerkerk@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2015-01-30 14:56:28]

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerWindowClient.h (right):

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerWindowClient.h:22: typedef
blink::WebServiceWorkerClientInfo WebType;
nit: omit namespace

https://codereview.chromium.org/850413002/diff/40001/public/web/WebServiceWor...
File public/web/WebServiceWorkerContextClient.h (right):

https://codereview.chromium.org/850413002/diff/40001/public/web/WebServiceWor...
public/web/WebServiceWorkerContextClient.h:159: // passed to the
WebServiceWorkerClientsCallbacks implementation.
WebServiceWorkerClientCallbacks

[mlamouri (slow - plz ping), 2015-02-02 16:09:26]

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.cpp (right):

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:91:
resolver->reject(DOMException::create(SecurityError, "'" + parsedUrl.string() +
"' is cross origin. It cannot be opened."));
On 2015/01/28 at 13:43:58, Mike West wrote:
> Nit: `parsedUrl.elidedString()`
> Nit2: How about 'is not same-origin with the Worker.'?

Done. Done.

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:95: if
(!context->isWindowInteractionAllowed()) {
On 2015/01/28 at 13:43:58, Mike West wrote:
> Where is this defined?

https://codereview.chromium.org/866983004

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:99:
context->consumeWindowInteraction();
On 2015/01/28 at 13:43:58, Mike West wrote:
> Ditto.

https://codereview.chromium.org/866983004

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerWindowClient.h (right):

https://codereview.chromium.org/850413002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerWindowClient.h:22: typedef
blink::WebServiceWorkerClientInfo WebType;
On 2015/01/30 at 14:56:28, Michael van Ouwerkerk wrote:
> nit: omit namespace

Done.

[mlamouri (slow - plz ping), 2015-02-04 23:28:07]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-02-04 23:29:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850413002/80001

[mlamouri (slow - plz ping), 2015-02-05 08:08:57]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-02-05 15:14:21]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-02-05 15:15:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/850413002/80001

[commit-bot: I haz the power, 2015-02-05 15:19:36]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189561

[philipj_slow, 2015-02-08 04:16:08]

I had some comments about the error handling on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/sb4WHR4Wdbk/ePk7UzBA...