Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 850383002: Add two way data binding. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add two way data binding. All reflected attributes two way bind on SkyElement, so now doing <sky-element name="sky-input" attributes="value:string"> is enough to get two way binding on the value attribute so users doing <sky-input value="{{ inputValue }}"> will get the inputValue property updated as the user types. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/04f96a9e12334f589b13b8b869a495e7e11ad96c

Patch Set 1 #

Patch Set 2 : Make it async. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -32 lines) Patch
M sky/examples/widgets/index.sky View 4 chunks +10 lines, -3 lines 0 comments Download
M sky/framework/sky-element/observe.sky View 5 chunks +7 lines, -13 lines 0 comments Download
M sky/framework/sky-element/sky-binder.sky View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 1 3 chunks +36 lines, -0 lines 0 comments Download
M sky/tests/framework/observe.sky View 2 chunks +3 lines, -7 lines 0 comments Download
M sky/tests/framework/observe-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/templates.sky View 1 2 chunks +38 lines, -1 line 0 comments Download
M sky/tests/framework/templates-expected.txt View 2 chunks +7 lines, -6 lines 0 comments Download
M sky/tests/resources/test-element.sky View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-15 20:37:29 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-15 22:15:11 UTC) #3
esprehn
5 years, 11 months ago (2015-01-15 23:03:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
04f96a9e12334f589b13b8b869a495e7e11ad96c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698