Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 850363005: VTTCue: Support 'auto' for line (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTCue.h
diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h
index 4bd268803f0e11839074fbd0b49691384525c235..a29f43a0eb341b79503df47a9d701c5ffae53abf 100644
--- a/Source/core/html/track/vtt/VTTCue.h
+++ b/Source/core/html/track/vtt/VTTCue.h
@@ -36,6 +36,7 @@
namespace blink {
class Document;
+class DoubleOrAutoKeyword;
class ExecutionContext;
class VTTCue;
class VTTScanner;
@@ -76,8 +77,8 @@ public:
bool snapToLines() const { return m_snapToLines; }
void setSnapToLines(bool);
- double line() const { return m_linePosition; }
- void setLine(double, ExceptionState&);
+ void line(DoubleOrAutoKeyword&) const;
+ void setLine(const DoubleOrAutoKeyword&);
double position() const { return m_textPosition; }
void setPosition(double, ExceptionState&);
@@ -188,6 +189,7 @@ private:
FloatPoint m_displayPosition;
bool m_snapToLines : 1;
+ bool m_lineIsAuto : 1;
philipj_slow 2015/01/20 14:52:31 How about using NaN for auto? Too clever?
fs 2015/01/20 16:35:16 I considered it, but since this is equally "free"
bool m_displayTreeShouldChange : 1;
bool m_notifyRegion : 1;
};

Powered by Google App Engine
This is Rietveld 408576698