LayoutTests/media/track/opera/interfaces/VTTCue/line.html - Issue 850363005: VTTCue: Support 'auto' for line

Side by Side Diff: LayoutTests/media/track/opera/interfaces/VTTCue/line.html

Issue 850363005: VTTCue: Support 'auto' for line (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <title>VTTCue.line</title>	2 <title>VTTCue.line</title>

3 <script src=../../../../../resources/testharness.js></script>	3 <script src=../../../../../resources/testharness.js></script>

4 <script src=../../../../../resources/testharnessreport.js></script>	4 <script src=../../../../../resources/testharnessreport.js></script>

5 <div id=log></div>	5 <div id=log></div>

6 <script>	6 <script>

7 test(function(){	7 test(function(){

8 var video = document.createElement('video');	8 var video = document.createElement('video');

9 document.body.appendChild(video);	9 document.body.appendChild(video);

10 var c1 = new VTTCue(0, 1, 'text1');	10 var c1 = new VTTCue(0, 1, 'text1');

11 assert_equals(c1.line, -1);	11 assert_equals(c1.line, 'auto');

12 var track = document.createElement('track');	12 var track = document.createElement('track');

13 var t = track.track;	13 var t = track.track;

14 t.addCue(c1);	14 t.addCue(c1);

15 assert_equals(c1.line, -1);	15 assert_equals(c1.line, 'auto');

16 video.appendChild(track);	16 video.appendChild(track);

17 assert_equals(c1.line, -1);	17 assert_equals(c1.line, 'auto');

18 t.mode = 'showing';	18 t.mode = 'showing';

19 assert_equals(c1.line, -1);	19 assert_equals(c1.line, 'auto');

20 var c2 = new VTTCue(0, 1, 'text2');	20 var c2 = new VTTCue(0, 1, 'text2');

21 var track2 = document.createElement('track');	21 var track2 = document.createElement('track');

22 var t2 = track2.track;	22 var t2 = track2.track;

23 t2.addCue(c2);	23 t2.addCue(c2);

24 assert_equals(c2.line, -1);	24 assert_equals(c2.line, 'auto');

25 video.appendChild(track2);	25 video.appendChild(track2);

26 t2.mode = 'showing';	26 t2.mode = 'showing';

27 assert_equals(c2.line, -2);	27 assert_equals(c2.line, 'auto');
philipj_slow 2015/01/20 14:52:31 I see that this -2 test used to fail. Was that per I see that this -2 test used to fail. Was that per spec when you implemented this in Presto, or what? (Just curious.) fs 2015/01/20 16:35:16 I'd think that "-2" is still the expected outcome Show quoted text On 2015/01/20 14:52:31, philipj wrote: > I see that this -2 test used to fail. Was that per spec when you implemented > this in Presto, or what? (Just curious.) I'd think that "-2" is still the expected outcome of the computed line position algorithm [1]. I think that the issue here was that VTTCue::line() just returned m_linePosition without validating state (see VTTCue.h). [1] http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-computed-line-position philipj_slow 2015/01/20 20:53:36 I see that the TextTrackCue.line getter in Presto Show quoted text On 2015/01/20 16:35:16, fs wrote: > On 2015/01/20 14:52:31, philipj wrote: > > I see that this -2 test used to fail. Was that per spec when you implemented > > this in Presto, or what? (Just curious.) > > I'd think that "-2" is still the expected outcome of the computed line position > algorithm [1]. I think that the issue here was that VTTCue::line() just returned > m_linePosition without validating state (see VTTCue.h). > > [1] http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-computed-line-position I see that the TextTrackCue.line getter in Presto was the computed line position, so I guess the spec said this at some point. fs 2015/01/21 09:00:12 Right, I missed to acknowledge that part. Show quoted text On 2015/01/20 20:53:36, philipj wrote: > On 2015/01/20 16:35:16, fs wrote: > > On 2015/01/20 14:52:31, philipj wrote: > > > I see that this -2 test used to fail. Was that per spec when you implemented > > > this in Presto, or what? (Just curious.) > > > > I'd think that "-2" is still the expected outcome of the computed line > position > > algorithm [1]. I think that the issue here was that VTTCue::line() just > returned > > m_linePosition without validating state (see VTTCue.h). > > > > [1] http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-computed-line-position > > I see that the TextTrackCue.line getter in Presto was the computed line > position, so I guess the spec said this at some point. Right, I missed to acknowledge that part.
28 assert_equals(c1.line, -1);	28 assert_equals(c1.line, 'auto');

29 c1.line = -5;	29 c1.line = -5;

30 assert_equals(c1.line, -5);	30 assert_equals(c1.line, -5);
philipj_slow 2015/01/20 14:52:31 Can you add a test for setting line to -1 since th Can you add a test for setting line to -1 since that used to be special? And NaN/Infinity somewhere. fs 2015/01/20 16:35:16 Done. (And looks like we found a bindings bug...) Show quoted text On 2015/01/20 14:52:31, philipj wrote: > Can you add a test for setting line to -1 since that used to be special? And > NaN/Infinity somewhere. Done. (And looks like we found a bindings bug...)
31 assert_equals(c2.line, -2);	31 assert_equals(c2.line, 'auto');

32 c1.line = 0;	32 c1.line = 0;

33 c1.snapToLines = false;	33 c1.snapToLines = false;

34 assert_equals(c1.line, 0);	34 assert_equals(c1.line, 0);

35 assert_equals(c2.line, -2);	35 assert_equals(c2.line, 'auto');

	36 assert_throws(new TypeError, function() { c1.line = 'auto\0'; });

	37 assert_equals(c1.line, 0);

36 }, document.title+', script-created cue');	38 }, document.title+', script-created cue');

37	39

38 var t_parsed = async_test(document.title+', parsed cue');	40 var t_parsed = async_test(document.title+', parsed cue');

39 t_parsed.step(function(){	41 t_parsed.step(function(){

40 var video = document.createElement('video');	42 var video = document.createElement('video');

41 document.body.appendChild(video);	43 document.body.appendChild(video);

42 var t = document.createElement('track');	44 var t = document.createElement('track');

43 t.onload = this.step_func(function(){	45 t.onload = this.step_func(function(){

44 var c1 = t.track.cues[0];	46 var c1 = t.track.cues[0];

45 var c2 = t.track.cues[1];	47 var c2 = t.track.cues[1];

46 var c3 = t.track.cues[2];	48 var c3 = t.track.cues[2];

47 assert_equals(c1.line, -1);	49 assert_equals(c1.line, 'auto');

48 assert_equals(c2.line, 0);	50 assert_equals(c2.line, 0);

49 assert_equals(c3.line, 0);	51 assert_equals(c3.line, 0);

50	52

51 this.done();	53 this.done();

52 });	54 });

53 t.src = 'data:text/vtt,'+encodeURIComponent('WEBVTT\n\n00:00:00.000 --> 00:0 0:00.001\ntest\n\n'+	55 t.src = 'data:text/vtt,'+encodeURIComponent('WEBVTT\n\n00:00:00.000 --> 00:0 0:00.001\ntest\n\n'+

54 '00:00:00.000 --> 00:00:00.001 l ine:0\ntest\n\n'+	56 '00:00:00.000 --> 00:00:00.001 l ine:0\ntest\n\n'+

55 '00:00:00.000 --> 00:00:00.001 l ine:0%\ntest');	57 '00:00:00.000 --> 00:00:00.001 l ine:0%\ntest');

56 t.track.mode = 'showing';	58 t.track.mode = 'showing';

57 video.appendChild(t);	59 video.appendChild(t);

58 });	60 });

59 </script>	61 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/track/opera/interfaces/VTTCue/line-expected.txt » ('j') | Source/core/html/track/vtt/VTTCue.h » ('J')