Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 850283003: Add a new webstorePrivate API to show a permission prompt for delegated installs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@testext_permission_prompt
Patch Set: allow dashboard Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 39cd574362e9cab2c1b1e0b051444b9a5bc1e010..aa6a10346e7df7bcc818c2c1f47c40a1797ec435 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -75,6 +75,7 @@ class ExtensionInstallPrompt
LAUNCH_PROMPT,
REMOTE_INSTALL_PROMPT,
REPAIR_PROMPT,
+ DELEGATED_PERMISSIONS_PROMPT,
NUM_PROMPT_TYPES
};
@@ -122,7 +123,6 @@ class ExtensionInstallPrompt
bool show_user_count,
double average_rating,
int rating_count);
- void SetUserNameFromProfile(Profile* profile);
PromptType type() const { return type_; }
void set_type(PromptType type) { type_ = type; }
@@ -188,6 +188,11 @@ class ExtensionInstallPrompt
retained_device_messages_ = retained_device_messages;
}
+ const std::string& username() const { return username_; }
+ void set_username(const std::string& username) {
+ username_ = username;
+ }
+
const gfx::Image& icon() const { return icon_; }
void set_icon(const gfx::Image& icon) { icon_ = icon; }
@@ -240,6 +245,8 @@ class ExtensionInstallPrompt
const extensions::Extension* extension_;
const extensions::BundleInstaller* bundle_;
+ std::string username_;
+
// The icon to be displayed.
gfx::Image icon_;
@@ -353,6 +360,16 @@ class ExtensionInstallPrompt
const extensions::Extension* extension,
const ShowDialogCallback& show_dialog_callback);
+ // This is called by the webstore API to verify the permissions for a
+ // delegated install.
+ //
+ // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
+ virtual void ConfirmPermissionsForDelegatedInstall(
+ Delegate* delegate,
+ const extensions::Extension* extension,
+ const std::string& delegated_username,
+ const SkBitmap* icon);
+
// This is called by the app handler launcher to verify whether the app
// should be re-enabled. This is declared virtual for testing.
//
@@ -438,6 +455,10 @@ class ExtensionInstallPrompt
// The bundle we are showing the UI for, if type BUNDLE_INSTALL_PROMPT.
const extensions::BundleInstaller* bundle_;
+ // The name of the user we are asking about, if type
+ // DELEGATED_PERMISSIONS_PROMPT.
+ std::string delegated_username_;
+
// A custom set of permissions to show in the install prompt instead of the
// extension's active permissions.
scoped_refptr<const extensions::PermissionSet> custom_permissions_;

Powered by Google App Engine
This is Rietveld 408576698