Add a new webstorePrivate API to show a permission prompt for delegated installs

chrome/browser/extensions/api/webstore_private/webstore_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_
 
 #include <string>
 
 #include "chrome/browser/extensions/active_install_data.h"
@@ skipping 140 matching lines @@
   // ExtensionFunction:
   bool RunAsync() override;
 
  private:
   scoped_ptr<WebstoreInstaller::Approval> approval_;
   scoped_ptr<ScopedActiveInstall> scoped_active_install_;
 
   void OnInstallSuccess(const std::string& id);
 };
 
+class WebstorePrivateShowPermissionPromptForDelegatedInstallFunction
+    : public ChromeAsyncExtensionFunction,
+      public ExtensionInstallPrompt::Delegate,
+      public WebstoreInstallHelper::Delegate {
+ public:
+  DECLARE_EXTENSION_FUNCTION(
+      "webstorePrivate.showPermissionPromptForDelegatedInstall",
+      WEBSTOREPRIVATE_SHOWPERMISSIONPROMPTFORDELEGATEDINSTALL)
+
+  // Result codes for the return value. If you change this, make sure to
+  // update the description for the showPermissionPromptForDelegatedInstall
+  // callback in the extension API JSON.
+  enum ResultCode {
+    ERROR_NONE = 0,

[not at google - send to devlin, 2015/02/04 21:28:29]

We should just formalise this as an enum in the schema, then reference it
directly when you need to use it.

launchEphemeralApp basically did it already, you just need to pull that enum out
into a common place. hopefully defining it as a type will work.
beginInstallWithManifestVersion3 should use the same enum.

Because, amusingly, it's already out of sync :)

This will clean up a bunch of code.

[Marc Treib, 2015/02/05 10:33:37]

Okay, that makes sense. I'll do that in a separate cleanup CL though, and then
rebase this one on top of it.

+
+    // An unspecified error occurred.
+    UNKNOWN_ERROR,
+
+    // The user cancelled the confirmation dialog instead of accepting it.
+    USER_CANCELLED,
+
+    // The manifest failed to parse correctly.
+    MANIFEST_ERROR,
+
+    // There was a problem parsing the base64 encoded icon data.
+    ICON_ERROR,
+
+    // The extension id was invalid.
+    INVALID_ID,
+
+    // Invalid icon url.
+    INVALID_ICON_URL,
+  };
+
+  WebstorePrivateShowPermissionPromptForDelegatedInstallFunction();
+
+  // WebstoreInstallHelper::Delegate:

[not at google - send to devlin, 2015/02/04 21:28:29]

All these delegate methods can be private, right?

[Marc Treib, 2015/02/05 10:33:37]

Indeed they can; I just mimicked what all the other WebStore private functions
do.
I've made mine private; for all the other functions, I'll do it in the separate
cleanup CL ^^.

+  void OnWebstoreParseSuccess(const std::string& id,
+                              const SkBitmap& icon,
+                              base::DictionaryValue* parsed_manifest) override;
+  void OnWebstoreParseFailure(const std::string& id,
+                              InstallHelperResultCode result_code,
+                              const std::string& error_message) override;
+
+  // ExtensionInstallPrompt::Delegate:
+  void InstallUIProceed() override;
+  void InstallUIAbort(bool user_initiated) override;
+
+ protected:
+  ~WebstorePrivateShowPermissionPromptForDelegatedInstallFunction() override;
+
+  // ExtensionFunction:
+  bool RunAsync() override;

[not at google - send to devlin, 2015/02/04 21:28:29]

Override Run() not RunAsync().

This will also let you clean up a bunch of code.

[Marc Treib, 2015/02/05 10:33:37]

This also applies to all the other WebstorePrivate functions, right? Oh well...
-> cleanup CL.

+
+  // Sets the result_ as a string based on |code|.
+  void SetResultCode(ResultCode code);
+
+ private:
+  const char* ResultCodeToString(ResultCode code);
+
+  // These store the input parameters to the function.
+  scoped_ptr<api::webstore_private::ShowPermissionPromptForDelegatedInstall::
+      Params> params_;
+
+  // The results of parsing manifest_ and icon_data_ go into these two.
+  scoped_ptr<base::DictionaryValue> parsed_manifest_;
+  SkBitmap icon_;
+
+  // A dummy Extension object we create for the purposes of using
+  // ExtensionInstallPrompt to prompt for confirmation of the install.
+  scoped_refptr<extensions::Extension> dummy_extension_;

[not at google - send to devlin, 2015/02/04 21:28:29]

This file is already in the extensions:: namespace

[Marc Treib, 2015/02/05 10:33:37]

Done.

+
+  // The class that displays the install prompt.
+  scoped_ptr<ExtensionInstallPrompt> install_prompt_;
+};
+
 class WebstorePrivateEnableAppLauncherFunction
     : public ChromeSyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webstorePrivate.enableAppLauncher",
                              WEBSTOREPRIVATE_ENABLEAPPLAUNCHER)
 
   WebstorePrivateEnableAppLauncherFunction();
 
  protected:
   ~WebstorePrivateEnableAppLauncherFunction() override;
@@ skipping 129 matching lines @@
  protected:
   ~WebstorePrivateGetEphemeralAppsEnabledFunction() override;
 
   // ExtensionFunction:
   bool RunSync() override;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_