Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 850263002: Revert of Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Auto-generate v8 version based on tags. (patchset #5 id:80001 of https://codereview.chromium.org/797503007/) Reason for revert: Blocks roll on android_aosp: https://codereview.chromium.org/851953005/ Original issue's description: > Auto-generate v8 version based on tags. > > BUG=chromium:446166 > LOG=y > > Committed: https://crrev.com/b301b85be895c6fcd1edfe2fd1e60b5abd0ac64d > Cr-Commit-Position: refs/heads/master@{#26062} TBR=jochen@chromium.org,jkummerow@chromium.org,tandrii@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:446166 Committed: https://crrev.com/28d99ef77f33d52f78f64cd2a7ba2c0049023ec9 Cr-Commit-Position: refs/heads/master@{#26067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -75 lines) Patch
M BUILD.gn View 4 chunks +1 line, -21 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +1 line, -35 lines 0 comments Download
M tools/push-to-trunk/generate_version.py View 2 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
Created Revert of Auto-generate v8 version based on tags.
5 years, 11 months ago (2015-01-15 08:00:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850263002/1
5 years, 11 months ago (2015-01-15 08:00:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 08:01:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28d99ef77f33d52f78f64cd2a7ba2c0049023ec9 Cr-Commit-Position: refs/heads/master@{#26067}
5 years, 11 months ago (2015-01-15 08:01:21 UTC) #4
Jakob Kummerow
rubberstamp LGTM
5 years, 11 months ago (2015-01-15 08:05:06 UTC) #5
Michael Achenbach
5 years, 11 months ago (2015-01-15 08:37:36 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/848913003/ by machenbach@chromium.org.

The reason for reverting is: Repairing aosp..

Powered by Google App Engine
This is Rietveld 408576698