Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 850193002: Makes create_snapshot_bin.py pass along a --package_root flag. (Closed)

Created:
5 years, 11 months ago by zra
Modified:
5 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Makes create_snapshot_bin.py pass along a --package_root flag. This allows a script snapshot to import from package: uris. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42887

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/tools/create_snapshot_bin.py View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
5 years, 11 months ago (2015-01-14 21:45:05 UTC) #2
siva
lgtm https://codereview.chromium.org/850193002/diff/1/runtime/tools/create_snapshot_bin.py File runtime/tools/create_snapshot_bin.py (right): https://codereview.chromium.org/850193002/diff/1/runtime/tools/create_snapshot_bin.py#newcode35 runtime/tools/create_snapshot_bin.py:35: help="Path used to resolve package: imports.") The help ...
5 years, 11 months ago (2015-01-14 21:49:50 UTC) #3
zra
https://codereview.chromium.org/850193002/diff/1/runtime/tools/create_snapshot_bin.py File runtime/tools/create_snapshot_bin.py (right): https://codereview.chromium.org/850193002/diff/1/runtime/tools/create_snapshot_bin.py#newcode35 runtime/tools/create_snapshot_bin.py:35: help="Path used to resolve package: imports.") On 2015/01/14 21:49:49, ...
5 years, 11 months ago (2015-01-14 21:59:18 UTC) #4
zra
5 years, 11 months ago (2015-01-14 21:59:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698