runtime/vm/dart.cc - Issue 850183003: During thread-pool shutdown, wait for worker threads to shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 850183003: During thread-pool shutdown, wait for worker threads to shutdown. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart.cc

===================================================================

--- runtime/vm/dart.cc (revision 45833)

+++ runtime/vm/dart.cc (working copy)

@@ -193,7 +193,7 @@

const char* Dart::Cleanup() {

// Shutdown the service isolate before shutting down the thread pool.

ServiceIsolate::Shutdown();

-#if 0

// Ideally we should shutdown the VM isolate here, but the thread pool

// shutdown does not seem to ensure that all the threads have stopped

// execution before it terminates, this results in racing isolates.

@@ -218,7 +218,6 @@

vm_isolate_ = NULL;

TargetCPUFeatures::Cleanup();

-#endif

Profiler::Shutdown();

CodeObservers::DeleteAll();

« no previous file with comments | « no previous file | runtime/vm/thread_pool.h » ('j') | no next file with comments »