Source/core/rendering/RenderHTMLCanvas.cpp - Issue 850143002: Ensure we remove floats from descendants even if they have become inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderHTMLCanvas.cpp

Issue 850143002: Ensure we remove floats from descendants even if they have become inline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderHTMLCanvas.cpp

diff --git a/Source/core/rendering/RenderHTMLCanvas.cpp b/Source/core/rendering/RenderHTMLCanvas.cpp

index a09c9fac38b4c60db4aad69415c65de73845f1bd..a98c72cda9b5cf3293607dbb3a786f2ec4fb04d0 100644

--- a/Source/core/rendering/RenderHTMLCanvas.cpp

+++ b/Source/core/rendering/RenderHTMLCanvas.cpp

@@ -71,16 +71,14 @@ void RenderHTMLCanvas::canvasSizeChanged()

if (!preferredLogicalWidthsDirty())

setPreferredLogicalWidthsDirty();

- if (selfNeedsLayout())

- return;

LayoutSize oldSize = size();

updateLogicalWidth();

updateLogicalHeight();

if (oldSize == size())

return;

- setNeedsLayout();

+ if (!selfNeedsLayout())

+ setNeedsLayout();

}

CompositingReasons RenderHTMLCanvas::additionalCompositingReasons() const

Julien - ping for review 2015/01/22 14:34:47 What happened to the test from https://codereview.

« Source/core/rendering/RenderBlockFlow.cpp ('K') | « Source/core/rendering/RenderBlockFlow.cpp ('k') | no next file » | no next file with comments »