Ensure we remove floats from descendants even if they have become inline

Source/core/rendering/RenderBlockFlow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1808 matching lines @@
         return;
     m_descendantsWithFloatsMarkedForLayout |= !floatToRemove;
 
     MarkingBehavior markParents = inLayout ? MarkOnlyThis : MarkContainingBlockChain;
     setChildNeedsLayout(markParents);
 
     if (floatToRemove)
         removeFloatingObject(floatToRemove);
 
     // Iterate over our children and mark them as needed.
-    if (!childrenInline()) {
+    if (!childrenInline() || floatToRemove) {

[Julien - ping for review, 2015/01/22 14:34:47]

Does the childrenInline check still make sense?

         for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
             if ((!floatToRemove && child->isFloatingOrOutOfFlowPositioned()) || !child->isRenderBlock())
                 continue;
             if (!child->isRenderBlockFlow()) {
                 RenderBlock* childBlock = toRenderBlock(child);
                 if (childBlock->shrinkToAvoidFloats() && childBlock->everHadLayout())
                     childBlock->setChildNeedsLayout(markParents);
                 continue;
             }
             RenderBlockFlow* childBlockFlow = toRenderBlockFlow(child);
@@ skipping 1281 matching lines @@
     FrameView* frameView = document().view();
     LayoutUnit top = (style()->position() == FixedPosition) ? 0 : frameView->scrollOffset().height();
     int visibleHeight = frameView->visibleContentRect(IncludeScrollbars).height();
     if (size().height() < visibleHeight)
         top += (visibleHeight - size().height()) / 2;
     setY(top);
     dialog->setCentered(top);
 }
 
 } // namespace blink