Source/core/frame/FrameView.cpp - Issue 850113003: iframe updates its parent scrollable area set when its visibility change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 850113003: iframe updates its parent scrollable area set when its visibility change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/scrollingcoordinator/non-fast-scrollable-visibility-change.html ('K') | « LayoutTests/scrollingcoordinator/non-fast-scrollable-visibility-change-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index 79c8bc6ed79e305da0bbcb7175273785db4eb902..fce2c7a32d275e9ca8bb26db99041b1e7fdcb85c 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -3958,6 +3958,7 @@ void FrameView::show()

{

if (!isSelfVisible()) {

setSelfVisible(true);

+ updateScrollableAreaSet();

if (isParentVisible()) {

for (const auto& child : m_children)

child->setParentVisible(true);

@@ -3975,6 +3976,7 @@ void FrameView::hide()

child->setParentVisible(false);

}

setSelfVisible(false);

+ updateScrollableAreaSet();

}

Widget::hide();