Issue 850093004: Remove dead TargetCollector code from the parser

Issue 850093004: Remove dead TargetCollector code from the parser (Closed)

Created:
5 years, 11 months ago by adamk

Modified:
5 years, 11 months ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove dead TargetCollector code from the parser This also simplifies target_stack_ and tightens up the types of nodes that can appear in it. Best I can tell, this code has been dead since https://code.google.com/p/v8/source/detail?r=7542 Committed: https://crrev.com/d3cd92a2f844352b4192c67ae51af1b651991701 Cr-Commit-Position: refs/heads/master@{#26083}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -93 lines)			Patch
M	src/ast.h	View	1	3 chunks	+1 line, -36 lines	0 comments	Download
M	src/ast.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/parser.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/parser.cc	View		13 chunks	+10 lines, -45 lines	0 comments	Download

Total messages: 7 (2 generated)

adamk

I happened to run into this code while reading the module-parsing code today.

5 years, 11 months ago (2015-01-15 01:48:37 UTC) #2

marja

lgtm, cool, thanks! Removing this code brings Parser and PreParser closer to each other too.

5 years, 11 months ago (2015-01-15 11:24:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850093004/20001

5 years, 11 months ago (2015-01-15 18:51:37 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 19:18:36 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/d3cd92a2f844352b4192c67ae51af1b651991701
Cr-Commit-Position: refs/heads/master@{#26083}