Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 850083002: Disable IndexedDBBrowserTest.ConnectionsClosedOnTabClose for Android ASAN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make the code less readable so people having displays from the 80s do not have to scroll right to s… Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_enumerator.h" 8 #include "base/files/file_enumerator.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 // ASSERT_DEATH/EXIT fails to work properly (on Windows) due to how we 690 // ASSERT_DEATH/EXIT fails to work properly (on Windows) due to how we
691 // implement the PRE_* test mechanism. 691 // implement the PRE_* test mechanism.
692 exit(0); 692 exit(0);
693 } 693 }
694 694
695 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, VersionChangeCrashResilience) { 695 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, VersionChangeCrashResilience) {
696 NavigateAndWaitForTitle(shell(), "version_change_crash.html", "#part3", 696 NavigateAndWaitForTitle(shell(), "version_change_crash.html", "#part3",
697 "pass - part3 - rolled back"); 697 "pass - part3 - rolled back");
698 } 698 }
699 699
700 // crbug.com/427529
701 // Disable this test for ASAN on Android because it takes too long to run.
702 #if defined(ANDROID) && defined(ADDRESS_SANITIZER)
703 #define MAYBE_ConnectionsClosedOnTabClose DISABLED_ConnectionsClosedOnTabClose
704 #else
705 #define MAYBE_ConnectionsClosedOnTabClose ConnectionsClosedOnTabClose
706 #endif
700 // Verify that open DB connections are closed when a tab is destroyed. 707 // Verify that open DB connections are closed when a tab is destroyed.
701 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, ConnectionsClosedOnTabClose) { 708 IN_PROC_BROWSER_TEST_F(
709 IndexedDBBrowserTest, MAYBE_ConnectionsClosedOnTabClose) {
702 NavigateAndWaitForTitle(shell(), "version_change_blocked.html", "#tab1", 710 NavigateAndWaitForTitle(shell(), "version_change_blocked.html", "#tab1",
703 "setVersion(2) complete"); 711 "setVersion(2) complete");
704 712
705 // Start on a different URL to force a new renderer process. 713 // Start on a different URL to force a new renderer process.
706 Shell* new_shell = CreateBrowser(); 714 Shell* new_shell = CreateBrowser();
707 NavigateToURL(new_shell, GURL(url::kAboutBlankURL)); 715 NavigateToURL(new_shell, GURL(url::kAboutBlankURL));
708 NavigateAndWaitForTitle(new_shell, "version_change_blocked.html", "#tab2", 716 NavigateAndWaitForTitle(new_shell, "version_change_blocked.html", "#tab2",
709 "setVersion(3) blocked"); 717 "setVersion(3) blocked");
710 718
711 base::string16 expected_title16(ASCIIToUTF16("setVersion(3) complete")); 719 base::string16 expected_title16(ASCIIToUTF16("setVersion(3) complete"));
(...skipping 29 matching lines...) Expand all
741 command_line->AppendSwitch(switches::kSingleProcess); 749 command_line->AppendSwitch(switches::kSingleProcess);
742 } 750 }
743 }; 751 };
744 752
745 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTestSingleProcess, 753 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTestSingleProcess,
746 RenderThreadShutdownTest) { 754 RenderThreadShutdownTest) {
747 SimpleTest(GetTestUrl("indexeddb", "shutdown_with_requests.html")); 755 SimpleTest(GetTestUrl("indexeddb", "shutdown_with_requests.html"));
748 } 756 }
749 757
750 } // namespace content 758 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698