Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 850073002: [turbofan] Allow 0.0 as immediate for floating-point comparison on arm/arm64. (Closed)

Created:
5 years, 11 months ago by baptiste.afsa1
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow 0.0 as immediate for floating-point comparison on arm/arm64. R=bmeurer@chromium.org Committed: https://crrev.com/51f3c66b64f55e03c489617f17b052e13026278e Cr-Commit-Position: refs/heads/master@{#26066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -12 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
baptiste.afsa1
PTAL
5 years, 11 months ago (2015-01-14 14:54:56 UTC) #1
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-15 05:30:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850073002/1
5 years, 11 months ago (2015-01-15 05:30:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 06:31:00 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 06:31:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f3c66b64f55e03c489617f17b052e13026278e
Cr-Commit-Position: refs/heads/master@{#26066}

Powered by Google App Engine
This is Rietveld 408576698