Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 850043009: Fix error introduced in extract_actions.py. (Closed)

Created:
5 years, 11 months ago by Alexei Svitkine (slow)
Modified:
5 years, 11 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix error introduced in extract_actions.py. Accidentally introduced by: https://codereview.chromium.org/848453002 Which added log.warning() instead of logging.warning() calls. TBR since this potentially broke presubmits for users. BUG=446197 TBR=isherman@chromium.org NOTRY=true Committed: https://crrev.com/3c6325c521785a399003f7529cc779de9d969595 Cr-Commit-Position: refs/heads/master@{#311626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/metrics/actions/extract_actions.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Alexei Svitkine (slow)
5 years, 11 months ago (2015-01-15 05:15:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850043009/1
5 years, 11 months ago (2015-01-15 05:15:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 05:17:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c6325c521785a399003f7529cc779de9d969595 Cr-Commit-Position: refs/heads/master@{#311626}
5 years, 11 months ago (2015-01-15 05:18:04 UTC) #5
Ilya Sherman
5 years, 11 months ago (2015-01-15 21:07:39 UTC) #6
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698