Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 850043003: Roll pdfium from f8105c5 to f731837. (Closed)

Created:
5 years, 11 months ago by rmcilroy
Modified:
5 years, 11 months ago
Reviewers:
etsepez, jochen (gone - plz use gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll pdfium from f8105c5 to f731837. Pulls in the following changes: f731837 - Fix v8 external snapshot code for Windows. 7900739 - Merge to master: Fix include paths for pdfium_unittests under chromium checkout 476cd69 - Add APIs for getting bookmarks and named destinations. BUG=421063, 439661 Committed: https://crrev.com/88cd03bab636648ef22bc34dee1e31941eb66e58 Cr-Commit-Position: refs/heads/master@{#311489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rmcilroy
PTAL, thanks.
5 years, 11 months ago (2015-01-14 15:30:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-14 15:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850043003/1
5 years, 11 months ago (2015-01-14 15:33:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 16:33:02 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:34:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88cd03bab636648ef22bc34dee1e31941eb66e58
Cr-Commit-Position: refs/heads/master@{#311489}

Powered by Google App Engine
This is Rietveld 408576698