Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 850033002: Remove dependency on dateutil in memory_inspector (Closed)

Created:
5 years, 11 months ago by petrcermak
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on dateutil in memory_inspector This patch is part of an ongoing process to unbundle memory_inspector and make it a chrome app. It removes the dependency of www_server.py on the dateutil module, which is not part of the Python Standard Library. BUG=448399 Committed: https://crrev.com/2ddff339b83714e75c8da7d0be99dbc3b4c3213b Cr-Commit-Position: refs/heads/master@{#311507}

Patch Set 1 #

Patch Set 2 : Reuse Archive._TIME_FMT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M tools/memory_inspector/memory_inspector/data/file_storage.py View 1 3 chunks +10 lines, -6 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_server.py View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
petrcermak
5 years, 11 months ago (2015-01-14 12:40:18 UTC) #2
petrcermak
I changed the code to reuse Archive._TIME_FMT as discussed offline. Petr
5 years, 11 months ago (2015-01-14 15:47:02 UTC) #3
Primiano Tucci (use gerrit)
LGTM. thanks
5 years, 11 months ago (2015-01-14 17:08:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850033002/20001
5 years, 11 months ago (2015-01-14 17:13:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 18:03:09 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:03:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ddff339b83714e75c8da7d0be99dbc3b4c3213b
Cr-Commit-Position: refs/heads/master@{#311507}

Powered by Google App Engine
This is Rietveld 408576698