Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850013003: [turbofan] Fix truncation/representation sloppiness wrt. bool/bit. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix truncation/representation sloppiness wrt. bool/bit. TEST=cctest,mjsunit,unittests BUG=v8:3812 LOG=y Committed: https://crrev.com/70b32e4b8a7d3f11174d0a68822d9a636fd1d127 Cr-Commit-Position: refs/heads/master@{#26051}

Patch Set 1 #

Patch Set 2 : Fixes/Cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -346 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +5 lines, -27 lines 0 comments Download
M src/compiler/js-graph.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/representation-change.h View 5 chunks +16 lines, -50 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 5 chunks +14 lines, -28 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +7 lines, -16 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 7 chunks +21 lines, -41 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -25 lines 0 comments Download
A + test/mjsunit/compiler/regress-3812.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/regress-bit-number-constant.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -22 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 2 chunks +0 lines, -72 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-14 11:19:54 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-14 11:42:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850013003/20001
5 years, 11 months ago (2015-01-14 11:43:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 12:06:50 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 12:07:04 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/70b32e4b8a7d3f11174d0a68822d9a636fd1d127
Cr-Commit-Position: refs/heads/master@{#26051}

Powered by Google App Engine
This is Rietveld 408576698