Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 849973002: Fix write_ordered_libraries.py for libraries with odd filenames (Closed)

Created:
5 years, 11 months ago by cjhopman
Modified:
5 years, 11 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix write_ordered_libraries.py for libraries with odd filenames Almost any character is valid in a filename. The rest of the pattern should be restrictive enough that we don't actually match anything that we don't want. BUG=427718 Committed: https://crrev.com/4a714c8d99004ed1f882f502dbe65d126e413b4b Cr-Commit-Position: refs/heads/master@{#311397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/write_ordered_libraries.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cjhopman
jdduke: *
5 years, 11 months ago (2015-01-14 01:17:47 UTC) #2
jdduke (slow)
lgtm, thanks.
5 years, 11 months ago (2015-01-14 01:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849973002/1
5 years, 11 months ago (2015-01-14 01:23:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 03:03:33 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 03:04:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a714c8d99004ed1f882f502dbe65d126e413b4b
Cr-Commit-Position: refs/heads/master@{#311397}

Powered by Google App Engine
This is Rietveld 408576698