Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 849933002: Change UI strings per request of UX team. (Closed)

Created:
5 years, 11 months ago by Bence
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, rolfe
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change UI strings per request of UX team. BUG=448147 Committed: https://crrev.com/dd4b7471b007b0f503859689f61a8d233ff7e42a Cr-Commit-Position: refs/heads/master@{#311508}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Re: #5. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Bence
PTAL.
5 years, 11 months ago (2015-01-13 20:54:25 UTC) #2
Bence
mmenke: PTAL. Thanks.
5 years, 11 months ago (2015-01-14 14:24:04 UTC) #4
mmenke
https://codereview.chromium.org/849933002/diff/1/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/849933002/diff/1/chrome/app/chromium_strings.grd#newcode999 chrome/app/chromium_strings.grd:999: and deselect &quot;<ph name="NO_PREFETCH_DESCRIPTION">&lt;span jscontent="noNetworkPredictionTitle"&gt;&lt;/span&gt;<ex>Prefetch resources to load pages ...
5 years, 11 months ago (2015-01-14 15:25:16 UTC) #5
Bence
PTAL. Thanks for catching those. https://codereview.chromium.org/849933002/diff/1/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/849933002/diff/1/chrome/app/chromium_strings.grd#newcode999 chrome/app/chromium_strings.grd:999: and deselect &quot;<ph name="NO_PREFETCH_DESCRIPTION">&lt;span ...
5 years, 11 months ago (2015-01-14 16:10:19 UTC) #6
mmenke
LGTM!
5 years, 11 months ago (2015-01-14 16:14:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849933002/20001
5 years, 11 months ago (2015-01-14 16:17:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 18:05:52 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:06:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd4b7471b007b0f503859689f61a8d233ff7e42a
Cr-Commit-Position: refs/heads/master@{#311508}

Powered by Google App Engine
This is Rietveld 408576698