[Cronet] Upload support for async APIs

components/cronet/android/java/src/org/chromium/net/UrlRequest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
+import java.util.concurrent.Executor;
+
 /**
  * HTTP request (GET, PUT or POST).
  * Note:  All methods must be called on the Executor passed in during creation.
  */
 public interface UrlRequest {
     public static final int REQUEST_PRIORITY_IDLE = 0;
 
     public static final int REQUEST_PRIORITY_LOWEST = 1;
 
     public static final int REQUEST_PRIORITY_LOW = 2;
@@ skipping 21 matching lines @@
 
     /**
      * Adds a request header. Must be done before request has started.
      *
      * @param header Header name
      * @param value Header value
      */
     public void addHeader(String header, String value);
 
     /**
+     * Sets upload data. Must be done before request has started. May only be
+     * invoked once per request. Switches method to "POST" if not explicitly
+     * set. Starting the request will throw an exception if a Content-Type
+     * header is not set.
+     *
+     * @param uploadDataProvider responsible for providing the upload data.
+     * @param executor All UploadDataProvider methods will be called using this

[pauljensen, 2015/02/12 17:15:40]

I think UploadDataProvider should not have the first letter capitalized.  I
think it should also be in {@code } braces.

[xunjieli, 2015/02/12 20:56:28]

Done.

+     *     executor. May optionally be the same executor the request itself is

[pauljensen, 2015/02/12 17:15:40]

I think both copies of "executor" on this line should have the first letter
capitalized and be in {@code } braces.

[xunjieli, 2015/02/12 20:56:28]

Done.

+     *     using.
+     */
+    public void setUploadDataProvider(UploadDataProvider uploadDataProvider, Executor executor);
+
+    /**
      * Starts the request, all callbacks go to listener. May only be called
      * once. May not be called if cancel has been called on the request.
      */
     public void start();
 
     /**
      * Cancels the request.
      *
      * Can be called at any time.  If the Executor passed to UrlRequest on
      * construction runs tasks on a single thread, and cancel is called on that
@@ skipping 38 matching lines @@
      */
     public void disableCache();
 
     /**
      * Note:  There are deliberately no accessors for the results of the request
      * here.  Having none removes any ambiguity over when they are populated,
      * particularly in the redirect case.
      */
 }