Issue 8499010: Optimize switch statements (second pass)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8499010: Optimize switch statements (second pass)

Created:
9 years, 1 month ago by indutny

Modified:
9 years ago

Reviewers:
vegerov, fschneider

CC:
v8-dev

Base URL:
gh:v8/v8@master

Visibility:
Public.

Description

Optimize switch statements (second pass) BUG= TEST= R=vegerov@chromium.org,fschneider@chromium.org

Patch Set 1 #

Patch Set 2 : sorry, merged with bleeding_edge #

Patch Set 3 : rebase on master #

Patch Set 4 : rebase on master #

Patch Set 5 : fix merge issues #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -7 lines)			Patch
	M	src/hydrogen.cc	View	1 2 3 4	5 chunks	+39 lines, -7 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years ago (2011-11-23 15:12:47 UTC) #1

I'm worried about the code size with this approach, especially if you have a
nested switch statement.

http://codereview.chromium.org/8499010/diff/5003/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/8499010/diff/5003/src/hydrogen.cc#newcode2887
src/hydrogen.cc:2887: CHECK_BAILOUT(VisitStatements(clause->statements()));
I think duplicating all clause bodies increases code size too much. There should
be only one body per clause.

Expand Messages | Collapse Messages