Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: sandbox/linux/services/credentials_unittest.cc

Issue 849893004: Move a couple of utility functions to a new namespace_utils class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments, fix broken test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/services/namespace_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/credentials_unittest.cc
diff --git a/sandbox/linux/services/credentials_unittest.cc b/sandbox/linux/services/credentials_unittest.cc
index 8b41917f7287939ffd94c193a3dce69e03413c28..eb0ff83f29e0722b4020e44a3a7cd6578a85fe64 100644
--- a/sandbox/linux/services/credentials_unittest.cc
+++ b/sandbox/linux/services/credentials_unittest.cc
@@ -71,9 +71,9 @@ SANDBOX_TEST(Credentials, MoveToNewUserNS) {
CHECK(!Credentials::HasAnyCapability());
}
-SANDBOX_TEST(Credentials, SupportsUserNS) {
+SANDBOX_TEST(Credentials, CanCreateProcessInNewUserNS) {
CHECK(Credentials::DropAllCapabilities());
- bool user_ns_supported = Credentials::SupportsNewUserNS();
+ bool user_ns_supported = Credentials::CanCreateProcessInNewUserNS();
bool moved_to_new_ns = Credentials::MoveToNewUserNS();
CHECK_EQ(user_ns_supported, moved_to_new_ns);
}
@@ -154,7 +154,7 @@ SANDBOX_TEST(Credentials, DISABLE_ON_LSAN(CannotRegainPrivileges)) {
// The kernel should now prevent us from regaining capabilities because we
// are in a chroot.
- CHECK(!Credentials::SupportsNewUserNS());
+ CHECK(!Credentials::CanCreateProcessInNewUserNS());
CHECK(!Credentials::MoveToNewUserNS());
}
« no previous file with comments | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/services/namespace_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698