Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 849873003: [CSS Shapes] Simplify LineWidth::wrapNextToShapeOutside() (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Shapes] Simplify LineWidth::wrapNextToShapeOutside() This function used to manually check to see if the entire height of the line would have enough space next to the float. However, the code to compute the offsets will do this automatically (and probably a lot faster), if the line height is passed in. This patch does just that. This is a merge of http://trac.webkit.org/changeset/178193 by Bem Jones-Bey <bjonesbe@adobe.com>;. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M Source/core/rendering/line/LineWidth.cpp View 3 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
PTAL
5 years, 11 months ago (2015-01-13 20:48:47 UTC) #2
Bem Jones-Bey (adobe)
lgtm
5 years, 11 months ago (2015-01-13 21:06:55 UTC) #3
rwlbuis
@leviw PTAL
5 years, 11 months ago (2015-01-13 21:32:56 UTC) #5
leviw_travelin_and_unemployed
Schweet. LGTM.
5 years, 11 months ago (2015-01-13 22:46:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849873003/1
5 years, 11 months ago (2015-01-13 22:47:09 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:09:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188340

Powered by Google App Engine
This is Rietveld 408576698