Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 849763002: Get rid of the full invalidation bool on FrameView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index 947b6bd267dac14af745a1765561b7ca4f977c87..4caeb5bddbae20b848ed4e74780571817aaa3db5 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -121,32 +121,6 @@ void RenderView::checkLayoutState()
}
#endif
-bool RenderView::shouldDoFullPaintInvalidationForNextLayout() const
-{
- // It's hard to predict here which of full paint invalidation or per-descendant paint invalidation costs less.
- // For vertical writing mode or width change it's more likely that per-descendant paint invalidation
- // eventually turns out to be full paint invalidation but with the cost to handle more layout states
- // and discrete paint invalidation rects, so marking full paint invalidation here is more likely to cost less.
- // Otherwise, per-descendant paint invalidation is more likely to avoid unnecessary full paint invalidation.
-
- if (width() != viewWidth())
- return true;
-
- if (height() != viewHeight()) {
- if (RenderObject* backgroundRenderer = this->backgroundRenderer()) {
- // When background-attachment is 'fixed', we treat the viewport (instead of the 'root'
- // i.e. html or body) as the background positioning area, and we should full paint invalidation
- // viewport resize if the background image is not composited and needs full paint invalidation on
- // background positioning area resize.
- if (backgroundRenderer->style()->hasFixedBackgroundImage()
- && mustInvalidateFillLayersPaintOnHeightChange(backgroundRenderer->style()->backgroundLayers()))
- return true;
- }
- }
-
- return false;
-}
-
void RenderView::layout()
{
SubtreeLayoutScope layoutScope(*this);
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698