Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 849763002: Get rid of the full invalidation bool on FrameView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index 233b32c3a3bb43efa057e4222713b08d4540d4c9..6759b8a979e68f8fe9dc6dc7227e0cf81c8a37d9 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -111,7 +111,6 @@ void FrameView::reset()
{
m_hasPendingLayout = false;
m_layoutSubtreeRoot = 0;
- m_doFullPaintInvalidation = false;
m_layoutSchedulingEnabled = true;
m_inPerformLayout = false;
m_canInvalidatePaintDuringPerformLayout = false;
@@ -350,17 +349,12 @@ void FrameView::layout(bool allowSubtree)
if (!inSubtreeLayout) {
if (m_firstLayout) {
- m_doFullPaintInvalidation = true;
m_firstLayout = false;
m_firstLayoutCallbackPending = true;
m_lastViewportSize = layoutSize(IncludeScrollbars);
}
m_size = LayoutSize(layoutSize().width(), layoutSize().height());
-
- // We need to set m_doFullPaintInvalidation before triggering layout as RenderObject::checkForPaintInvalidation
- // checks the boolean to disable local paint invalidations.
- m_doFullPaintInvalidation |= renderView()->shouldDoFullPaintInvalidationForNextLayout();
}
layer = rootForThisLayout->enclosingLayer();
@@ -403,7 +397,6 @@ void FrameView::layout(bool allowSubtree)
void FrameView::invalidateTreeIfNeeded()
{
lifecycle().advanceTo(DocumentLifecycle::InPaintInvalidation);
- m_doFullPaintInvalidation = false;
lifecycle().advanceTo(DocumentLifecycle::PaintInvalidationClean);
}
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698