Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Side by Side Diff: sky/engine/core/frame/FrameView.h

Issue 849763002: Get rid of the full invalidation bool on FrameView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/DocumentLifecycle.h ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Methods for getting/setting the size Blink should use to layout the conte nts. 94 // Methods for getting/setting the size Blink should use to layout the conte nts.
95 // FIXME(sky): Remove the scrollbars argument now that FrameView doesn't scr oll. 95 // FIXME(sky): Remove the scrollbars argument now that FrameView doesn't scr oll.
96 IntSize layoutSize(IncludeScrollbarsInRect = ExcludeScrollbars) const; 96 IntSize layoutSize(IncludeScrollbarsInRect = ExcludeScrollbars) const;
97 void setLayoutSize(const IntSize&); 97 void setLayoutSize(const IntSize&);
98 98
99 // If this is set to false, the layout size will need to be explicitly set b y the owner. 99 // If this is set to false, the layout size will need to be explicitly set b y the owner.
100 // E.g. WebViewImpl sets its mainFrame's layout size manually 100 // E.g. WebViewImpl sets its mainFrame's layout size manually
101 void setLayoutSizeFixedToFrameSize(bool isFixed) { m_layoutSizeFixedToFrameS ize = isFixed; } 101 void setLayoutSizeFixedToFrameSize(bool isFixed) { m_layoutSizeFixedToFrameS ize = isFixed; }
102 bool layoutSizeFixedToFrameSize() { return m_layoutSizeFixedToFrameSize; } 102 bool layoutSizeFixedToFrameSize() { return m_layoutSizeFixedToFrameSize; }
103 103
104 bool needsFullPaintInvalidation() const { return m_doFullPaintInvalidation; }
105
106 void recalcOverflowAfterStyleChange(); 104 void recalcOverflowAfterStyleChange();
107 105
108 bool isEnclosedInCompositingLayer() const; 106 bool isEnclosedInCompositingLayer() const;
109 107
110 void prepareForDetach(); 108 void prepareForDetach();
111 109
112 void clear(); 110 void clear();
113 111
114 bool isTransparent() const; 112 bool isTransparent() const;
115 void setTransparent(bool isTransparent); 113 void setTransparent(bool isTransparent);
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 return !isInPerformLayout() || canInvalidatePaintDuringPerformLayout(); 234 return !isInPerformLayout() || canInvalidatePaintDuringPerformLayout();
237 } 235 }
238 236
239 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache 237 static double s_currentFrameTimeStamp; // used for detecting decoded resourc e thrash in the cache
240 static bool s_inPaintContents; 238 static bool s_inPaintContents;
241 239
242 LayoutSize m_size; 240 LayoutSize m_size;
243 241
244 RefPtr<LocalFrame> m_frame; 242 RefPtr<LocalFrame> m_frame;
245 243
246 bool m_doFullPaintInvalidation;
247
248 bool m_hasPendingLayout; 244 bool m_hasPendingLayout;
249 RenderObject* m_layoutSubtreeRoot; 245 RenderObject* m_layoutSubtreeRoot;
250 246
251 bool m_layoutSchedulingEnabled; 247 bool m_layoutSchedulingEnabled;
252 bool m_inPerformLayout; 248 bool m_inPerformLayout;
253 bool m_canInvalidatePaintDuringPerformLayout; 249 bool m_canInvalidatePaintDuringPerformLayout;
254 bool m_inSynchronousPostLayout; 250 bool m_inSynchronousPostLayout;
255 int m_layoutCount; 251 int m_layoutCount;
256 unsigned m_nestedLayoutCount; 252 unsigned m_nestedLayoutCount;
257 Timer<FrameView> m_postLayoutTasksTimer; 253 Timer<FrameView> m_postLayoutTasksTimer;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 m_view->setCanInvalidatePaintDuringPerformLayout(m_originalValue); 306 m_view->setCanInvalidatePaintDuringPerformLayout(m_originalValue);
311 } 307 }
312 private: 308 private:
313 FrameView* m_view; 309 FrameView* m_view;
314 bool m_originalValue; 310 bool m_originalValue;
315 }; 311 };
316 312
317 } // namespace blink 313 } // namespace blink
318 314
319 #endif // SKY_ENGINE_CORE_FRAME_FRAMEVIEW_H_ 315 #endif // SKY_ENGINE_CORE_FRAME_FRAMEVIEW_H_
OLDNEW
« no previous file with comments | « sky/engine/core/dom/DocumentLifecycle.h ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698