Plugin Power Saver: Make PepperPluginInstanceThrottler interface public.

content/public/renderer/render_frame.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_
 
 #include "base/callback_forward.h"
 #include "base/strings/string16.h"
 #include "content/common/content_export.h"
@@ skipping 18 matching lines @@
 }
 
 namespace v8 {
 template <typename T> class Handle;
 class Context;
 class Isolate;
 }
 
 namespace content {
 class ContextMenuClient;
+class PluginInstanceThrottler;
 class RenderView;
 class ServiceRegistry;
 struct ContextMenuParams;
 struct WebPluginInfo;
 struct WebPreferences;
 
 // This interface wraps functionality, which is specific to frames, such as
 // navigation. It provides communication with a corresponding RenderFrameHost
 // in the browser process.
 class CONTENT_EXPORT RenderFrame : public IPC::Listener,
                                    public IPC::Sender {
  public:
-  enum PluginPowerSaverMode {
-    // Plugin content is main content, and therefore never throttled.
-    POWER_SAVER_MODE_ESSENTIAL = 0,
-    // Plugin content is peripheral, but throttling is disabled.
-    POWER_SAVER_MODE_PERIPHERAL_UNTHROTTLED = 1,
-    // Plugin content is peripheral, and throttling is enabled.
-    POWER_SAVER_MODE_PERIPHERAL_THROTTLED = 2
-  };
-
   // Returns the RenderFrame given a WebFrame.
   static RenderFrame* FromWebFrame(blink::WebFrame* web_frame);
 
   // Returns the RenderView associated with this frame.
   virtual RenderView* GetRenderView() = 0;
 
   // Get the routing ID of the frame.
   virtual int GetRoutingID() = 0;
 
   // Returns the associated WebFrame.
@@ skipping 17 matching lines @@
                               const ContextMenuParams& params) = 0;
 
   // Cancels a context menu in the event that the client is destroyed before the
   // menu is closed.
   virtual void CancelContextMenu(int request_id) = 0;
 
   // Gets the node that the context menu was pressed over.
   virtual blink::WebNode GetContextMenuNode() const = 0;
 
   // Create a new NPAPI/Pepper plugin depending on |info|. Returns NULL if no
-  // plugin was found.
+  // plugin was found. |throttler| may be NULL.

[Bernhard Bauer, 2015/01/13 23:29:36]

Nit: s/NULL/nullptr/? :)

[tommycli, 2015/01/14 01:44:59]

Done.

   virtual blink::WebPlugin* CreatePlugin(
       blink::WebFrame* frame,
       const WebPluginInfo& info,
       const blink::WebPluginParams& params,
-      PluginPowerSaverMode power_saver_mode) = 0;
+      PluginInstanceThrottler* throttler) = 0;

[Bernhard Bauer, 2015/01/13 23:29:36]

This takes ownership of |throttler|, right? In which case, pass a scoped_ptr?

[tommycli, 2015/01/14 01:45:00]

Done.

 
   // The client should handle the navigation externally.
   virtual void LoadURLExternally(blink::WebLocalFrame* frame,
                                  const blink::WebURLRequest& request,
                                  blink::WebNavigationPolicy policy) = 0;
 
   // Execute a string of JavaScript in this frame's context.
   virtual void ExecuteJavaScript(const base::string16& javascript) = 0;
 
   // Return true if this frame is hidden.
@@ skipping 65 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderFrameImpl;
   RenderFrame() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_