Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 849693007: Merge to XFA: Add embeddertests. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add embeddertests. This brings in: 83f96a0 Add API tests: NamedDestsByName, DestGetPageIndex. 9dcd7b8 Add tests for GetNamedDests() API. TBR=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/c8f6ab628c4bdf90dcee3d5ac153beb043a42f92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -1 line) Patch
A fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 2 chunks +137 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/named_dests.in View 1 chunk +109 lines, -0 lines 0 comments Download
A testing/resources/named_dests.pdf View 1 chunk +135 lines, -0 lines 0 comments Download
A testing/tools/fixup_pdf_template.py View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tom Sepez
5 years, 11 months ago (2015-01-22 19:20:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8f6ab628c4bdf90dcee3d5ac153beb043a42f92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698