Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 849693002: wifi_sync: add FakeWifiConfigDelegate (Closed)

Created:
5 years, 11 months ago by mukesh agrawal
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@submit-4.2-wifi-config-delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wifi_sync: add FakeWifiConfigDelegate FakeWifiConfigDelegate is a simple fake, which gives us the ability to tell how many times a method is has been called. BUG=chromium:431435 TEST=components_unittests --gtest_filter="Wifi*"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/wifi_sync/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/wifi_sync/fake_wifi_config_delegate.h View 1 chunk +37 lines, -0 lines 0 comments Download
A components/wifi_sync/fake_wifi_config_delegate.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mukesh agrawal
Seems to be uncommon to write unit tests for fakes, so I've omitted unit tests ...
5 years, 11 months ago (2015-01-12 20:53:25 UTC) #3
erikwright (departed)
Do you already have multiple unit-tests that will use this? It's helpful to include links ...
5 years, 11 months ago (2015-01-12 20:58:09 UTC) #5
mukesh agrawal
On 2015/01/12 20:58:09, erikwright wrote: > Do you already have multiple unit-tests that will use ...
5 years, 11 months ago (2015-01-12 21:05:16 UTC) #6
erikwright (departed)
On 2015/01/12 21:05:16, mukesh agrawal wrote: > On 2015/01/12 20:58:09, erikwright wrote: > > Do ...
5 years, 11 months ago (2015-01-13 18:39:08 UTC) #7
stevenjb
On 2015/01/13 18:39:08, erikwright wrote: > On 2015/01/12 21:05:16, mukesh agrawal wrote: > > On ...
5 years, 11 months ago (2015-01-13 23:02:01 UTC) #8
mukesh agrawal
5 years, 11 months ago (2015-01-14 01:16:50 UTC) #9
Rolling into next CL. (Will move the code into the WCSS unit tests file.)

Powered by Google App Engine
This is Rietveld 408576698