Issue 84963007: Fix crash in TraceLog::UpdateTraceEventDuration()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 84963007: Fix crash in TraceLog::UpdateTraceEventDuration() (Closed)

Created:
7 years ago by Xianzhu

Modified:
7 years ago

Reviewers:
nduca

CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in TraceLog::UpdateTraceEventDuration() Because we don't lock when getting event_callback_, there will be chance that it has been set to NULL in SetEventCallbackDisabled() in another thread, but category_group_enabled has not been updated yet. Always check if event_callback is NULL before calling it. BUG=323016 TBR=nduca NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237096

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	base/debug/trace_event_impl.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/84963007/1

7 years ago (2013-11-25 17:22:32 UTC) #1

Message was sent while issue was closed.

Change committed as 237096

Expand Messages | Collapse Messages