Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 84963003: Add candidatewindow* events related IPCs (Closed)

Created:
7 years ago by kochi
Modified:
7 years ago
CC:
haraken, chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, Chris Evans
Visibility:
Public.

Description

Add candidatewindow* events related IPCs These IPCs correspond to Javascript IME API events (oncandidatewindow*) defined in https://dvcs.w3.org/hg/ime-api/raw-file/8c061ee19f99/Overview.html#inputmethodcontext-interface They will fire when IME candidate window changes its appearance. The Blink side of the change is already checked in: https://src.chromium.org/viewvc/blink?revision=161139&view=revision This is the Chromium part of sending IPCs to renderer and a test for both Chromium and Blink code path, which is not covered by blink r161139. The whole change FYI is worked on at https://codereview.chromium.org/80583002/ and other CLs (to generate actual events from IMEs etc.) will follow. BUG=238585 TEST=content_browsertests --gtest_filter="RenderViewImplTest.SendCandidateWindowEvents" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238282

Patch Set 1 #

Patch Set 2 : fix renames #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kochi
cevans@chromium.org: Please review changes in view_messages.h jamesr@chromium.org: Please review changes in content/renderer/* sky@chromium.org: Please review ...
7 years ago (2013-11-27 01:38:38 UTC) #1
jamesr
What do these messages mean?
7 years ago (2013-11-27 01:43:59 UTC) #2
kochi
On 2013/11/27 01:43:59, jamesr wrote: > What do these messages mean? Sorry for the terse ...
7 years ago (2013-11-27 01:52:00 UTC) #3
kochi
+jln, as cevans is on vacation - could you review view_messages.h? I assume most other ...
7 years ago (2013-11-28 11:49:26 UTC) #4
kochi
On 2013/11/28 11:49:26, Takayoshi Kochi wrote: > +jln, as cevans is on vacation - could ...
7 years ago (2013-12-02 08:42:55 UTC) #5
Ben Goodger (Google)
rwhva lgtm
7 years ago (2013-12-02 18:57:50 UTC) #6
sky
content/browser LGTM
7 years ago (2013-12-02 22:05:34 UTC) #7
jln (very slow on Chromium)
content/common/view_messages.h lgtm
7 years ago (2013-12-02 22:09:57 UTC) #8
jamesr
content/renderer lgtm
7 years ago (2013-12-02 22:18:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/84963003/90001
7 years ago (2013-12-03 00:28:16 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-03 03:16:18 UTC) #11
Message was sent while issue was closed.
Change committed as 238282

Powered by Google App Engine
This is Rietveld 408576698