Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 849543003: Make elevation icon size correct in different DPI settings (Closed)

Created:
5 years, 11 months ago by xiaoling
Modified:
5 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make elevation icon size correct in different DPI settings BUG=449731 Committed: https://crrev.com/5a36bfe017b8c4408b8816246e07abcec96e0781 Cr-Commit-Position: refs/heads/master@{#312458}

Patch Set 1 #

Patch Set 2 : fix build error #

Total comments: 2

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/ui/views/elevation_icon_setter.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xiaoling
5 years, 11 months ago (2015-01-21 19:57:48 UTC) #2
Peter Kasting
LGTM
5 years, 11 months ago (2015-01-21 20:17:46 UTC) #3
Peter Kasting
https://codereview.chromium.org/849543003/diff/20001/chrome/browser/ui/views/elevation_icon_setter.cc File chrome/browser/ui/views/elevation_icon_setter.cc (right): https://codereview.chromium.org/849543003/diff/20001/chrome/browser/ui/views/elevation_icon_setter.cc#newcode77 chrome/browser/ui/views/elevation_icon_setter.cc:77: device_scale_factor = gfx::GetDPIScale(); Actually you might want a comment ...
5 years, 11 months ago (2015-01-21 20:18:37 UTC) #4
xiaoling
ty https://codereview.chromium.org/849543003/diff/20001/chrome/browser/ui/views/elevation_icon_setter.cc File chrome/browser/ui/views/elevation_icon_setter.cc (right): https://codereview.chromium.org/849543003/diff/20001/chrome/browser/ui/views/elevation_icon_setter.cc#newcode77 chrome/browser/ui/views/elevation_icon_setter.cc:77: device_scale_factor = gfx::GetDPIScale(); On 2015/01/21 20:18:37, Peter Kasting ...
5 years, 11 months ago (2015-01-21 20:23:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849543003/40001
5 years, 11 months ago (2015-01-21 20:25:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 21:29:38 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:30:28 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5a36bfe017b8c4408b8816246e07abcec96e0781
Cr-Commit-Position: refs/heads/master@{#312458}

Powered by Google App Engine
This is Rietveld 408576698