Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 849523002: NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case We can remove Plugin::NexeFileDidOpenContinuation(), which gets called via the "init_done" SRPC call (which calls StartupInitializationComplete() in plugin/service_runtime.cc). Its work gets done by the newer ManifestServiceProxy::StartupInitializationComplete() in components/nacl/renderer/ppb_nacl_private_impl.cc, which gets called via Chrome IPC (by the "PpapiHostMsg_StartupInitializationComplete" message). ppapi_dispatcher.cc: In order to keep the error handling tests in NaClBrowserTestNewlib.Bad passing, send the StartupInitializationComplete message earlier, before we call PPP_InitializeModule(). This ensures that crashes in PPP_InitializeModule() are reported properly. Note that PNaCl still relies on "init_done" for now. BUG=428030 BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 Committed: https://crrev.com/4c03d4d0964b0b69f5741aac6c78557b415617e1 Cr-Commit-Position: refs/heads/master@{#311298}

Patch Set 1 #

Patch Set 2 : Reduce scope to non-PNaCl #

Patch Set 3 : Cleanup #

Patch Set 4 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 3 2 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark Seaborn
5 years, 11 months ago (2015-01-13 16:28:32 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-13 17:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849523002/60001
5 years, 11 months ago (2015-01-13 17:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-13 18:50:42 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4c03d4d0964b0b69f5741aac6c78557b415617e1 Cr-Commit-Position: refs/heads/master@{#311298}
5 years, 11 months ago (2015-01-13 18:51:32 UTC) #7
Mark Seaborn
5 years, 11 months ago (2015-01-14 06:16:12 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/793723006/ by mseaborn@chromium.org.

The reason for reverting is: Reverting this change because it appears to cause
NaClBrowserTestNewlib.Bad to become flaky.

BUG=448596.

Powered by Google App Engine
This is Rietveld 408576698