Fix FileSystemExtensionApiTest.FileBrowserTest

Fix FileSystemExtensionApiTest.FileBrowserTest

BUG=103406
TEST=FileBrowserExtensionApiTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109351

[tbarzic, 2011-11-09 03:26:24]

Hey Vyacheslav,

could you take a look at this.

I will make more investigation about how GC handles FileReader objects, but for
now, this should be ok..

Thanks

[Vyacheslav Egorov (Chromium), 2011-11-09 11:34:11]

It's looks fine as a temporary solution to me.

I am not a chromium commiter so my LGTM is useless :-)

[zel, 2011-11-09 21:04:50]

LGTM

with nits

http://codereview.chromium.org/8495044/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/filesystem_handler/tab.html (right):

http://codereview.chromium.org/8495044/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/filesystem_handler/tab.html:80: var reader;
i wouldn't do this one

http://codereview.chromium.org/8495044/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/filesystem_handler/tab.html:92: reader =
new FileReader();
put var back

[commit-bot: I haz the power, 2011-11-09 21:12:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8495044/6001

[Vyacheslav Egorov (Chromium), 2011-11-09 21:14:04]

Hmm, now it will start failing again cause global reader was intended to prevent
it from failing.

[tbarzic, 2011-11-09 21:20:26]

On 2011/11/09 21:14:04, Vyacheslav Egorov wrote:
> Hmm, now it will start failing again cause global reader was intended to
prevent
> it from failing.

I tried it locally, and it doesn't hang.. If it starts failing, I'll change
reader to be global again..

[Vyacheslav Egorov (Chromium), 2011-11-09 21:30:07]

it might be that by removing runTests you affected GC timing and this have also
hidden original problem as successfully as making reader global does (which as I
understand we still have not tracked down to the root cause).

[tbarzic, 2011-11-09 21:42:42]

On 2011/11/09 21:30:07, Vyacheslav Egorov wrote:
> it might be that by removing runTests you affected GC timing and this have
also
> hidden original problem as successfully as making reader global does (which as
I
> understand we still have not tracked down to the root cause).

I agree, but also I feel that making reader global is not the best (long term)
solution, so I would not do it unless we really have to..

[commit-bot: I haz the power, 2011-11-09 21:54:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8495044/6001

[commit-bot: I haz the power, 2011-11-10 00:46:14]

Try job failure for 8495044-6001 (retry) (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...