Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 8495044: Fix FileSystemExtensionApiTest.FileBrowserTest (Closed)

Created:
9 years, 1 month ago by tbarzic
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix FileSystemExtensionApiTest.FileBrowserTest BUG=103406 TEST=FileBrowserExtensionApiTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109351

Patch Set 1 #

Total comments: 2

Patch Set 2 : make reader local again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M chrome/browser/extensions/extension_local_filesystem_apitest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler/tab.html View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tbarzic
Hey Vyacheslav, could you take a look at this. I will make more investigation about ...
9 years, 1 month ago (2011-11-09 03:26:24 UTC) #1
Vyacheslav Egorov (Chromium)
It's looks fine as a temporary solution to me. I am not a chromium commiter ...
9 years, 1 month ago (2011-11-09 11:34:11 UTC) #2
tbarzic
9 years, 1 month ago (2011-11-09 17:16:52 UTC) #3
zel
LGTM with nits http://codereview.chromium.org/8495044/diff/1/chrome/test/data/extensions/api_test/filesystem_handler/tab.html File chrome/test/data/extensions/api_test/filesystem_handler/tab.html (right): http://codereview.chromium.org/8495044/diff/1/chrome/test/data/extensions/api_test/filesystem_handler/tab.html#newcode80 chrome/test/data/extensions/api_test/filesystem_handler/tab.html:80: var reader; i wouldn't do this ...
9 years, 1 month ago (2011-11-09 21:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8495044/6001
9 years, 1 month ago (2011-11-09 21:12:25 UTC) #5
Vyacheslav Egorov (Chromium)
Hmm, now it will start failing again cause global reader was intended to prevent it ...
9 years, 1 month ago (2011-11-09 21:14:04 UTC) #6
tbarzic
On 2011/11/09 21:14:04, Vyacheslav Egorov wrote: > Hmm, now it will start failing again cause ...
9 years, 1 month ago (2011-11-09 21:20:26 UTC) #7
Vyacheslav Egorov (Chromium)
it might be that by removing runTests you affected GC timing and this have also ...
9 years, 1 month ago (2011-11-09 21:30:07 UTC) #8
tbarzic
On 2011/11/09 21:30:07, Vyacheslav Egorov wrote: > it might be that by removing runTests you ...
9 years, 1 month ago (2011-11-09 21:42:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8495044/6001
9 years, 1 month ago (2011-11-09 21:54:09 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-10 00:46:14 UTC) #11
Try job failure for 8495044-6001 (retry) (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698