Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 849363002: Disable geolocation infobar tests. (Closed)

Created:
5 years, 11 months ago by newt (away)
Modified:
5 years, 11 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable geolocation infobar tests. These are briefly broken because location is disabled on test devices, and the mechanism for mocking out system location settings was broken. To be fixed shortly. BUG=449341 NOTRY=true Committed: https://crrev.com/f9b1f3bd8064eaa8383781f9b79a2e512098bd81 Cr-Commit-Position: refs/heads/master@{#311774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 11 months ago (2015-01-15 23:52:46 UTC) #2
nyquist
lgtm
5 years, 11 months ago (2015-01-16 00:15:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849363002/1
5 years, 11 months ago (2015-01-16 00:17:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:31:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:32:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9b1f3bd8064eaa8383781f9b79a2e512098bd81
Cr-Commit-Position: refs/heads/master@{#311774}

Powered by Google App Engine
This is Rietveld 408576698