Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 849333002: use log2(scale) to compute mip level (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use log2(scale) to compute mip level BUG=skia: Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9

Patch Set 1 #

Patch Set 2 : use correct log_base_2 #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : use real log2 #

Patch Set 5 : and work-around for android for log2f #

Patch Set 6 : fix stupid warning #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M include/core/SkFloatingPoint.h View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M include/core/SkScalar.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkMipMap.cpp View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
reed1
5 years, 11 months ago (2015-01-15 22:26:58 UTC) #2
reed1
won't land until this lands first https://codereview.chromium.org/857463002/
5 years, 11 months ago (2015-01-15 22:28:05 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/849333002/diff/40001/include/core/SkFloatingPoint.h File include/core/SkFloatingPoint.h (right): https://codereview.chromium.org/849333002/diff/40001/include/core/SkFloatingPoint.h#newcode91 include/core/SkFloatingPoint.h:91: #define sk_float_log(x) logf(x) Map sk_float_log2 to log2f here?
5 years, 11 months ago (2015-01-16 01:13:38 UTC) #6
reed1
https://codereview.chromium.org/849333002/diff/40001/include/core/SkFloatingPoint.h File include/core/SkFloatingPoint.h (right): https://codereview.chromium.org/849333002/diff/40001/include/core/SkFloatingPoint.h#newcode91 include/core/SkFloatingPoint.h:91: #define sk_float_log(x) logf(x) On 2015/01/16 01:13:37, robertphillips wrote: > ...
5 years, 11 months ago (2015-01-16 13:00:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849333002/60001
5 years, 11 months ago (2015-01-16 13:01:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1501)
5 years, 11 months ago (2015-01-16 13:04:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849333002/80001
5 years, 11 months ago (2015-01-16 14:24:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1505)
5 years, 11 months ago (2015-01-16 14:26:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849333002/100001
5 years, 11 months ago (2015-01-16 14:42:12 UTC) #17
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-16 14:42:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849333002/120001
5 years, 11 months ago (2015-01-16 15:08:34 UTC) #21
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9
5 years, 11 months ago (2015-01-16 15:18:14 UTC) #22
reed1
5 years, 11 months ago (2015-01-16 15:26:41 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/856783004/ by reed@google.com.

The reason for reverting is: need more suppressions.

Powered by Google App Engine
This is Rietveld 408576698