Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: components/history.gypi

Issue 849323002: Componentize HistoryDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history.gypi
diff --git a/components/history.gypi b/components/history.gypi
index cde78051ab035de00520a782b7467296d7f1fa29..8deb012478c51aa9216ca9c176ae8639bb2b880f 100644
--- a/components/history.gypi
+++ b/components/history.gypi
@@ -40,6 +40,10 @@
'history/core/browser/history_constants.cc',
'history/core/browser/history_constants.h',
'history/core/browser/history_context.h',
+ 'history/core/browser/history_database.cc',
+ 'history/core/browser/history_database.h',
+ 'history/core/browser/history_database_params.cc',
+ 'history/core/browser/history_database_params.h',
'history/core/browser/history_db_task.h',
'history/core/browser/history_match.cc',
'history/core/browser/history_match.h',
@@ -75,6 +79,19 @@
'history/core/browser/visitsegment_database.cc',
'history/core/browser/visitsegment_database.h',
],
+ 'conditions': [
+ ['OS=="android"', {
+ 'sources': [
+ 'history/core/browser/android/android_cache_database.cc',
+ 'history/core/browser/android/android_cache_database.h',
+ 'history/core/browser/android/android_history_types.cc',
+ 'history/core/browser/android/android_history_types.h',
+ 'history/core/browser/android/android_time.h',
+ 'history/core/browser/android/android_urls_database.cc',
+ 'history/core/browser/android/android_urls_database.h',
+ ],
+ }],
+ ],
},
{
# GN version: //components/history/core/browser:proto
@@ -127,6 +144,8 @@
'history/core/test/history_client_fake_bookmarks.h',
'history/core/test/history_unittest_base.cc',
'history/core/test/history_unittest_base.h',
+ 'history/core/test/test_history_database.cc',
+ 'history/core/test/test_history_database.h',
],
},
],
@@ -150,6 +169,8 @@
'history/content/browser/download_constants_utils.h',
'history/content/browser/history_context_helper.cc',
'history/content/browser/history_context_helper.h',
+ 'history/content/browser/history_database_helper.cc',
+ 'history/content/browser/history_database_helper.h',
],
}
],
@@ -169,13 +190,6 @@
'history_core_browser',
],
'sources': [
- 'history/core/android/android_cache_database.cc',
- 'history/core/android/android_cache_database.h',
- 'history/core/android/android_history_types.cc',
- 'history/core/android/android_history_types.h',
- 'history/core/android/android_time.h',
- 'history/core/android/android_urls_database.cc',
- 'history/core/android/android_urls_database.h',
'history/core/android/android_urls_sql_handler.cc',
'history/core/android/android_urls_sql_handler.h',
'history/core/android/favicon_sql_handler.cc',

Powered by Google App Engine
This is Rietveld 408576698