Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 849303003: Top-level pages should show left-navigation. (Closed)

Created:
5 years, 11 months ago by mkearney1
Modified:
5 years, 11 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The new left-nav wasn't showing up for the top-level parents. This is because there's a dependency between the selected item, and showing the selected item's child elements in the navigation. Adding redirects is a quick solution. But we should tweak the logic for rendering the navigation to do this better. Created a bug to make this happen: https://code.google.com/p/chromium/issues/detail?id=449272 I also added the nativeMessaging article to chrome_sidenav.json so it's not an orphan page (and so it gets a left-side navigation). BUG=447853 Committed: https://crrev.com/7dbc1428fa4363ff47972c2076cd4395e05e9440 Cr-Commit-Position: refs/heads/master@{#311775}

Patch Set 1 #

Patch Set 2 : Small title fix for nativeMessaging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M chrome/common/extensions/docs/templates/articles/nativeMessaging.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/redirects.json View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mkearney1
Iterating on navigation to make it better (this is likely to go on for a ...
5 years, 11 months ago (2015-01-15 21:18:24 UTC) #2
paulirish
lgtm. i'm OK with the redirects as a quick solution. love the new left-nav.
5 years, 11 months ago (2015-01-15 23:27:10 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 11 months ago (2015-01-15 23:37:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849303003/20001
5 years, 11 months ago (2015-01-15 23:42:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:32:25 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:34:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dbc1428fa4363ff47972c2076cd4395e05e9440
Cr-Commit-Position: refs/heads/master@{#311775}

Powered by Google App Engine
This is Rietveld 408576698