Cleanup extension permissions module.

chrome/browser/extensions/permissions_updater_unittest.cc

Index: chrome/browser/extensions/permissions_updater_unittest.cc
diff --git a/chrome/browser/extensions/permissions_updater_unittest.cc b/chrome/browser/extensions/permissions_updater_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..30e38def2e38fd5b0a5720bb1e1bb0476743592e
--- /dev/null
+++ b/chrome/browser/extensions/permissions_updater_unittest.cc
@@ -0,0 +1,210 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/file_path.h"
+#include "base/json/json_value_serializer.h"
+#include "base/memory/ref_counted.h"
+#include "base/path_service.h"
+#include "base/values.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_service_unittest.h"
+#include "chrome/browser/extensions/permissions_updater.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_permission_set.h"
+#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_service.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+// A helper class that listens for NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED.
+class PermissionsUpdaterListener : public content::NotificationObserver {
+ public:
+  PermissionsUpdaterListener()
+      : received_notification_(false), waiting_(false) {
+    registrar_.Add(this,
+                   chrome::NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED,
+                   content::NotificationService::AllSources());
+  }
+
+  void Reset() {
+    received_notification_ = false;
+    waiting_ = false;
+    extension_ = NULL;
+    permissions_ = NULL;
+  }
+
+  void Wait() {
+    if (received_notification_)
+      return;
+
+    waiting_ = true;
+    ui_test_utils::RunMessageLoop();
+  }
+
+  bool received_notification() const { return received_notification_; }
+  const Extension* extension() const { return extension_; }
+  const ExtensionPermissionSet* permissions() const { return permissions_; }
+  UpdatedExtensionPermissionsInfo::Reason reason() const {
+    return reason_;
+  }
+
+ private:
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE {
+    received_notification_ = true;
+    UpdatedExtensionPermissionsInfo* info =
+        content::Details<UpdatedExtensionPermissionsInfo>(details).ptr();
+
+    extension_ = info->extension;
+    permissions_ = info->permissions;
+    reason_ = info->reason;
+
+    if (waiting_) {
+      waiting_ = false;
+      MessageLoopForUI::current()->Quit();
+    }
+  }
+
+  bool received_notification_;
+  bool waiting_;
+  content::NotificationRegistrar registrar_;
+  scoped_refptr<const Extension> extension_;
+  scoped_refptr<const ExtensionPermissionSet> permissions_;
+  UpdatedExtensionPermissionsInfo::Reason reason_;
+};
+
+class PermissionsUpdaterTest : public ExtensionServiceTestBase {
+};
+
+scoped_refptr<Extension> LoadManifest(std::string* error) {
+  FilePath path;
+  PathService::Get(chrome::DIR_TEST_DATA, &path);
+  path = path.AppendASCII("extensions")
+      .AppendASCII("api_test")
+      .AppendASCII("permissions")
+      .AppendASCII("optional")
+      .AppendASCII("manifest.json");
+
+  JSONFileValueSerializer serializer(path);
+  scoped_ptr<Value> result(serializer.Deserialize(NULL, error));
+  if (!result.get())
+    return NULL;
+
+  scoped_refptr<Extension> extension = Extension::Create(
+      path.DirName(), Extension::INTERNAL,
+      *static_cast<DictionaryValue*>(result.get()), Extension::NO_FLAGS, error);
+  return extension;
+}
+
+void AddPattern(URLPatternSet* extent, const std::string& pattern) {
+  int schemes = URLPattern::SCHEME_ALL;
+  extent->AddPattern(URLPattern(schemes, pattern));
+}
+
+}  // namespace
+
+// Test that the PermissionUpdater can correctly add and remove active
+// permissions. This tests all of PermissionsUpdater's public methods because
+// GrantActivePermissions and UpdateActivePermissions are used by
+// AddPermissions.
+TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
+  InitializeEmptyExtensionService();
+
+  // Load the test extension.
+  std::string error;
+  scoped_refptr<Extension> extension = LoadManifest(&error);
+  ASSERT_TRUE(error.empty()) << error;
+
+  ExtensionAPIPermissionSet default_apis;
+  default_apis.insert(ExtensionAPIPermission::kManagement);
+  URLPatternSet default_hosts;
+  AddPattern(&default_hosts, "http://a.com/*");
+  scoped_refptr<ExtensionPermissionSet> default_permissions =
+      new ExtensionPermissionSet(default_apis, default_hosts, URLPatternSet());
+
+  // Make sure it loaded properly.
+  scoped_refptr<const ExtensionPermissionSet> permissions =
+      extension->GetActivePermissions();
+  ASSERT_EQ(*default_permissions, *extension->GetActivePermissions());
+
+  // Add a few permissions.
+  ExtensionAPIPermissionSet apis;
+  apis.insert(ExtensionAPIPermission::kTab);
+  apis.insert(ExtensionAPIPermission::kNotification);
+  URLPatternSet hosts;
+  AddPattern(&hosts, "http://*.c.com/*");
+
+  scoped_refptr<ExtensionPermissionSet> delta =
+      new ExtensionPermissionSet(apis, hosts, URLPatternSet());
+
+  PermissionsUpdaterListener listener;
+  PermissionsUpdater updater(profile_.get());
+  updater.AddPermissions(extension.get(), delta.get());
+
+  listener.Wait();
+
+  // Verify that the permission notification was sent correctly.
+  ASSERT_TRUE(listener.received_notification());
+  ASSERT_EQ(extension, listener.extension());
+  ASSERT_EQ(UpdatedExtensionPermissionsInfo::ADDED, listener.reason());
+  ASSERT_EQ(*delta, *listener.permissions());
+
+  // Make sure the extension's active permissions reflect the change.
+  scoped_refptr<ExtensionPermissionSet> active_permissions =
+      ExtensionPermissionSet::CreateUnion(default_permissions, delta);
+  ASSERT_EQ(*active_permissions, *extension->GetActivePermissions());
+
+  // Verify that the new granted and active permissions were also stored
+  // in the extension preferences. In this case, the granted permissions should
+  // be equal to the active permissions.
+  ExtensionPrefs* prefs = service_->extension_prefs();
+  scoped_refptr<ExtensionPermissionSet> granted_permissions =
+      active_permissions;
+
+  scoped_refptr<ExtensionPermissionSet> from_prefs =
+      prefs->GetActivePermissions(extension->id());
+  ASSERT_EQ(*active_permissions, *from_prefs);
+
+  from_prefs = prefs->GetGrantedPermissions(extension->id());
+  ASSERT_EQ(*active_permissions, *from_prefs);
+
+  // In the second part of the test, we'll remove the permissions that we
+  // just added except for 'notification'.
+  apis.erase(ExtensionAPIPermission::kNotification);
+  delta = new ExtensionPermissionSet(apis, hosts, URLPatternSet());
+
+  listener.Reset();
+  updater.RemovePermissions(extension, delta);
+  listener.Wait();
+
+  // Verify that the notification was correct.
+  ASSERT_TRUE(listener.received_notification());
+  ASSERT_EQ(extension, listener.extension());
+  ASSERT_EQ(UpdatedExtensionPermissionsInfo::REMOVED, listener.reason());
+  ASSERT_EQ(*delta, *listener.permissions());
+
+  // Make sure the extension's active permissions reflect the change.
+  active_permissions =
+      ExtensionPermissionSet::CreateDifference(active_permissions, delta);
+  ASSERT_EQ(*active_permissions, *extension->GetActivePermissions());
+
+  // Verify that the extension prefs hold the new active permissions and the
+  // same granted permissions.
+  from_prefs = prefs->GetActivePermissions(extension->id());
+  ASSERT_EQ(*active_permissions, *from_prefs);
+
+  from_prefs = prefs->GetGrantedPermissions(extension->id());
+  ASSERT_EQ(*granted_permissions, *from_prefs);
+}
+
+}  // namespace extensions