Adding assert for better debugging.

Adding assert for better debugging.

BUG=447462
Committed: https://crrev.com/ca89606dbdcde6e82ed2b0cbe7b0e8e7b121946a
Cr-Commit-Position: refs/heads/master@{#314227}

[aiolos (Not reviewing), 2015-01-16 18:42:46]

aiolos@chromium.org changed reviewers:
+ nednguyen@google.com

[aiolos (Not reviewing), 2015-01-16 18:50:03]

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
File tools/telemetry/telemetry/wpr/archive_info.py (right):

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
tools/telemetry/telemetry/wpr/archive_info.py:79: return
I'm torn on whether to return here or not return here and change the name of the
function and how it's called. If the archive has no bucket, they shouldn't be
trying to pull anything from cloud_storage because it isn't needed, and the
documentation for this function makes the assumption that we won't update teh
archives in that case.

Opinions?

[nednguyen, 2015-01-17 16:17:59]

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
File tools/telemetry/telemetry/wpr/archive_info.py (right):

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
tools/telemetry/telemetry/wpr/archive_info.py:79: return
On 2015/01/16 18:50:03, aiolos wrote:
> I'm torn on whether to return here or not return here and change the name of
the
> function and how it's called. If the archive has no bucket, they shouldn't be
> trying to pull anything from cloud_storage because it isn't needed, and the
> documentation for this function makes the assumption that we won't update teh
> archives in that case.
> 
> Opinions?
Ok to me if documentation does describe the situation.

On another note, if bucket is required for WprArchiveInfo to work, I think
bucket should be stored in wpr archive file. 

If two different page sets point to a same wpr archive file, and those two
specify different bucket, they can get two different sets of recordings, which
sounds like a bug to me.

[nednguyen, 2015-01-20 20:39:47]

lgtm

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
File tools/telemetry/telemetry/wpr/archive_info.py (right):

https://codereview.chromium.org/849293003/diff/1/tools/telemetry/telemetry/wp...
tools/telemetry/telemetry/wpr/archive_info.py:80: assert 'archives' in
self._data
Can you add debugging message, s.t like:
'Invalid data format in %s. \'archives\' field is needed' % archive_path

[aiolos (Not reviewing), 2015-02-02 22:11:58]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2015-02-02 22:13:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/849293003/20001

[commit-bot: I haz the power, 2015-02-03 00:39:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-03 00:41:11]

Patchset 2 (id:??) landed as
https://crrev.com/ca89606dbdcde6e82ed2b0cbe7b0e8e7b121946a
Cr-Commit-Position: refs/heads/master@{#314227}